Refactor and clean up the code

Author: daxian-dbw

shell/agents/AIShell.PhiSilica.Agent/AIShell.PhiSilica.Agent.csproj

@@ -1,21 +1,18 @@
 <Project Sdk="Microsoft.NET.Sdk">
-
   <PropertyGroup>
-	  <OutputType>Library</OutputType>
-	  <TargetFramework>net8.0-windows10.0.26100.0</TargetFramework>
-	  <ImplicitUsings>enable</ImplicitUsings>
-	  <Nullable>enable</Nullable>
-	  <Platforms>AnyCPU</Platforms>
-	  <WindowsPackageType>None</WindowsPackageType>
-	  <EnableDynamicLoading>true</EnableDynamicLoading>
-	  <WindowsAppSdkBootstrapInitialize>true</WindowsAppSdkBootstrapInitialize>
-	  <WindowsAppSDKSelfContained>true</WindowsAppSDKSelfContained>
-	  <RuntimeIdentifier>win-arm64</RuntimeIdentifier>
-      <EnableMsixTooling>true</EnableMsixTooling>
-
+    <OutputType>Library</OutputType>
+    <TargetFramework>net8.0-windows10.0.26100.0</TargetFramework>
+    <ImplicitUsings>enable</ImplicitUsings>
+    <NoWarn>CS8305</NoWarn>
+    <Platforms>AnyCPU</Platforms>
+    <WindowsPackageType>None</WindowsPackageType>
+    <EnableDynamicLoading>true</EnableDynamicLoading>
+    <WindowsAppSdkBootstrapInitialize>true</WindowsAppSdkBootstrapInitialize>
+    <WindowsAppSDKSelfContained>true</WindowsAppSDKSelfContained>
+    <RuntimeIdentifier>win-arm64</RuntimeIdentifier>
+    <EnableMsixTooling>true</EnableMsixTooling>
   </PropertyGroup>
 
-
   <ItemGroup>
     <ProjectReference Include="..\..\AIShell.Abstraction\AIShell.Abstraction.csproj">
       <!-- Disable copying AIShell.Abstraction.dll to output folder -->
@@ -25,7 +22,6 @@
     </ProjectReference>
   </ItemGroup>
 
-
   <ItemGroup>
     <PackageReference Include="Microsoft.WindowsAppSDK" Version="1.8.250410001-experimental1" />
   </ItemGroup>

shell/agents/AIShell.PhiSilica.Agent/PhiSilicaAgent.cs

@@ -1,69 +1,97 @@
-
-using Microsoft.Windows.AI.Generative;
-
 using AIShell.Abstraction;
 using Microsoft.Windows.AI;
+using Microsoft.Windows.AI.Generative;
 
-namespace AIShell.PhiSilica.Agent
+namespace AIShell.PhiSilica.Agent;
+
+public sealed partial class PhiSilicaAgent : ILLMAgent
 {
-    public class PhiSilicaAgent : ILLMAgent
-    {
-        public string Name => "PhiSilica";
+    private readonly Task _initTask;
+    private LanguageModel _model;
 
-        public string Description => "This is the Phi Silica agent, an offline local agent on Copilot+ PCs";
+    public string Name => "PhiSilica";
+    public string Description => "This is the Phi Silica agent, an offline local agent on Copilot+ PCs";
+    public string SettingFile => null;
 
-        public string SettingFile => null;
+    public IEnumerable<CommandBase> GetCommands() => null;
+    public bool CanAcceptFeedback(UserAction action) => false;
+    public Task RefreshChatAsync(IShell shell, bool force) => Task.CompletedTask;
+    public void OnUserAction(UserActionPayload actionPayload) { }
+    public void Initialize(AgentConfig config) { }
+    public void Dispose() { }
 
-        public bool CanAcceptFeedback(UserAction action) => false;
+    public PhiSilicaAgent()
+    {
+        // Start the initialization for AI feature and model on a background thread.
+        _initTask = Task.Run(InitFeatureAndModelAsync);
+    }
 
+    private async Task InitFeatureAndModelAsync()
+    {
+        AIFeatureReadyState state = LanguageModel.GetReadyState();
+        if (state is AIFeatureReadyState.NotSupportedOnCurrentSystem)
+        {
+            throw new PlatformNotSupportedException("The Phi Silica feature is not supported on current system.");
+        }
 
-        public async Task<bool> ChatAsync(string input, IShell shell)
+        if (state is AIFeatureReadyState.DisabledByUser)
         {
-            IHost host = shell.Host;
-            if (LanguageModel.GetReadyState() == AIFeatureReadyState.EnsureNeeded)
-            {
-                var op = await LanguageModel.EnsureReadyAsync();
+            throw new PlatformNotSupportedException("The Phi Silica feature is currently disabled.");
+        }
 
+        if (state is AIFeatureReadyState.EnsureNeeded)
+        {
+            // Initialize the WinRT runtime.
+            AIFeatureReadyResult result = await LanguageModel.EnsureReadyAsync();
+            // Do not proceed if it failed to get the feature ready.
+            if (result.Status is not AIFeatureReadyResultState.Success)
+            {
+                throw new InvalidOperationException(result.ErrorDisplayText, result.Error);
             }
+        }
 
-            var languageModel = await LanguageModel.CreateAsync();
+        _model = await LanguageModel.CreateAsync();
+    }
 
-            var results = await languageModel.GenerateResponseAsync(input);
+    public async Task<bool> ChatAsync(string input, IShell shell)
+    {
+        IHost host = shell.Host;
 
-            if (results != null && !string.IsNullOrEmpty(results.Text))
+        try
+        {
+            // Wait for the init task to finish. Once it's finished, calling this again is a non-op.
+            await _initTask;
+        }
+        catch (Exception e)
+        {
+            host.WriteErrorLine(e.Message);
+            if (e is InvalidOperationException && e.InnerException is not null)
             {
-                host.RenderFullResponse(results.Text);
+                host.WriteErrorLine(e.InnerException.StackTrace);
             }
-            else
+            else if (e is not PlatformNotSupportedException)
             {
-                host.WriteErrorLine("No response received from the language model.");
+                // Show stack trace for non-PNS exception.
+                host.WriteErrorLine(e.StackTrace);
             }
-            //host.RenderFullResponse("Goodbye World");
 
-            return true;
+            return false;
         }
 
-        public void Dispose()
-        {
-           
-        }
+        var result = await host.RunWithSpinnerAsync(
+            status: "Thinking ...",
+            func: async () => await _model.GenerateResponseAsync(input)
+        );
 
-        public IEnumerable<CommandBase> GetCommands() => null;
-
-        public void Initialize(AgentConfig config)
+        if (result is not null && !string.IsNullOrEmpty(result.Text))
         {
-            
+            host.RenderFullResponse(result.Text);
         }
-
-        public void OnUserAction(UserActionPayload actionPayload)
+        else
         {
-            
+            host.WriteErrorLine("No response received from the language model.");
         }
 
-        public Task RefreshChatAsync(IShell shell, bool force)
-        {
-            return Task.CompletedTask;
-        }
+        return true;
     }
-
 }