Update code and remove ids from exception telemetry

Author: daxian-dbw

shell/agents/Microsoft.Azure.Agent/AzureAgent.cs

@@ -121,34 +121,39 @@ public void Initialize(AgentConfig config)
 
     public IEnumerable<CommandBase> GetCommands() => [new ReplaceCommand(this)];
     public bool CanAcceptFeedback(UserAction action) => Telemetry.Enabled;
-    public void OnUserAction(UserActionPayload actionPayload) {
+
+    public void OnUserAction(UserActionPayload actionPayload)
+    {
         // Send telemetry about the user action.
         bool isUserFeedback = false;
-        bool allowIdsForCorrelation = false;
+        bool shareConversation = false;
         string details = null;
-        UserAction action = actionPayload.Action;
+        string action = actionPayload.Action.ToString();
 
-        if (action is UserAction.Dislike)
-        {
-            isUserFeedback = true;
-            DislikePayload dislike = (DislikePayload)actionPayload;
-            allowIdsForCorrelation = dislike.ShareConversation;
-            details = string.Format("{0} | {1}", dislike.ShortFeedback, dislike.LongFeedback);
-        }
-        else if (action is UserAction.Like)
+        switch (actionPayload)
         {
-            isUserFeedback = true;
-            LikePayload like = (LikePayload)actionPayload;
-            allowIdsForCorrelation = like.ShareConversation;
+            case DislikePayload dislike:
+                isUserFeedback = true;
+                shareConversation = dislike.ShareConversation;
+                details = string.Format("{0} | {1}", dislike.ShortFeedback, dislike.LongFeedback);
+                break;
+
+            case LikePayload like:
+                isUserFeedback = true;
+                shareConversation = like.ShareConversation;
+                break;
+
+            default:
+                break;
         }
 
         if (isUserFeedback)
         {
-            Telemetry.Trace(AzTrace.Feedback(action.ToString(), _copilotResponse, details, allowIdsForCorrelation));
+            Telemetry.Trace(AzTrace.Feedback(action, shareConversation, _copilotResponse, details));
         }
         else
         {
-            Telemetry.Trace(AzTrace.UserAction(action.ToString(), _copilotResponse, details));
+            Telemetry.Trace(AzTrace.UserAction(action, _copilotResponse, details));
         }
     }
 
@@ -423,7 +428,7 @@ private ResponseData ParseCLIHandlerResponse(IShell shell)
         {
             // The placeholder section is not in the format as we've instructed ...
             Log.Error("Placeholder section not in expected format:\n{0}", text);
-            Telemetry.Trace(AzTrace.Exception(_copilotResponse, "Placeholder section not in expected format."));
+            Telemetry.Trace(AzTrace.Exception("Placeholder section not in expected format."));
         }
 
         ReplaceKnownPlaceholders(data);

shell/agents/Microsoft.Azure.Agent/ChatSession.cs

@@ -14,7 +14,6 @@ internal class ChatSession : IDisposable
     // TODO: production URL not yet working for some regions.
     // private const string ACCESS_URL = "https://copilotweb.production.portalrp.azure.com/api/access?api-version=2024-09-01";
     private const string ACCESS_URL = "https://copilotweb.canary.production.portalrp.azure.com/api/access?api-version=2024-09-01";
-
     private const string DL_TOKEN_URL = "https://copilotweb.production.portalrp.azure.com/api/conversations/start?api-version=2024-11-15";
     private const string CONVERSATION_URL = "https://directline.botframework.com/v3/directline/conversations";
 

shell/agents/Microsoft.Azure.Agent/Telemetry.cs

@@ -94,9 +94,9 @@ internal static AzTrace UserAction(
         {
             return new()
             {
-                TopicName = response.TopicName,
-                ShellCommand = shellCommand,
                 EventType = "UserAction",
+                ShellCommand = shellCommand,
+                TopicName = response.TopicName,
                 Details = details
             };
         }
@@ -107,19 +107,19 @@ internal static AzTrace UserAction(
 
     internal static AzTrace Feedback(
         string shellCommand,
+        bool shareConversation,
         CopilotResponse response,
-        object details,
-        bool allowIdsForCorrelation)
+        object details)
     {
         if (Telemetry.Enabled)
         {
             return new()
             {
-                QueryId = allowIdsForCorrelation ? response.ReplyToId : null,
-                TopicName = response.TopicName,
-                ConversationId = allowIdsForCorrelation ? response.ConversationId : null,
-                ShellCommand = shellCommand,
                 EventType = "Feedback",
+                ShellCommand = shellCommand,
+                TopicName = response.TopicName,
+                QueryId = shareConversation ? response.ReplyToId : null,
+                ConversationId = shareConversation ? response.ConversationId : null,
                 Details = details
             };
         }