feedback 1_3

Author: Andrew

dsc/src/main.rs

@@ -34,7 +34,7 @@ fn main() {
 
     let args = Args::parse();
 
-    util::enable_tracing(args.trace_level, args.trace_format);
+    util::enable_tracing(&args.trace_level, &args.trace_format);
 
     debug!("Running dsc {}", env!("CARGO_PKG_VERSION"));
 

dsc/src/util.rs

@@ -291,7 +291,7 @@ pub fn write_output(json: &str, format: &Option<OutputFormat>) {
     }
 }
 
-pub fn enable_tracing(trace_level_arg: Option<TraceLevel>, trace_format_arg: Option<TraceFormat>) {
+pub fn enable_tracing(trace_level_arg: &Option<TraceLevel>, trace_format_arg: &Option<TraceFormat>) {
 
     let mut policy_is_used = false;
     let mut tracing_setting = TracingSetting::default();

dsc_lib/src/util.rs

@@ -59,6 +59,7 @@ pub fn parse_input_to_json(value: &str) -> Result<String, DscError> {
 }
 
 /// Will search setting files for the specified setting.
+/// Performance implication: Use this function economically as every call opens/reads several config files.
 ///
 /// # Arguments
 ///