add TODO note on validating properties

Steve Lee (POWERSHELL HE/HIM) (from Dev Box) · Steve Lee (POWERSHELL HE/HIM) (from Dev Box) · commit 4721a10830c9 · 2024-09-15T07:38:48.000-07:00
diff --git a/wmi-adapter/wmi.resource.ps1 b/wmi-adapter/wmi.resource.ps1
@@ -96,7 +96,7 @@ elseif ($Operation -eq 'Get')
             $wmi_namespace = $type_fields[0].Replace('.','\')
             $wmi_classname = $type_fields[1]
 
-            #TODO: identify key properties and add WHERE clause to the query
+            # TODO: identify key properties and add WHERE clause to the query
             if ($r.properties)
             {
                 $query = "SELECT $($r.properties.psobject.properties.name -join ',') FROM $wmi_classname"
@@ -105,6 +105,7 @@ elseif ($Operation -eq 'Get')
                 $first = $true
                 foreach ($property in $r.properties.psobject.properties)
                 {
+                    # TODO: validate property against the CIM class to give better error message
                     if ($null -ne $property.value)
                     {
                         $useWhere = $true

Original file line number	Diff line number	Diff line change
`@@ -96,7 +96,7 @@ elseif ($Operation -eq 'Get')`
`96`	`96`	`$wmi_namespace = $type_fields[0].Replace('.','\')`
`97`	`97`	`$wmi_classname = $type_fields[1]`
`98`	`98`
`99`		`- #TODO: identify key properties and add WHERE clause to the query`
	`99`	`+ # TODO: identify key properties and add WHERE clause to the query`
`100`	`100`	`if ($r.properties)`
`101`	`101`	`{`
`102`	`102`	`$query = "SELECT $($r.properties.psobject.properties.name -join ',') FROM $wmi_classname"`
`@@ -105,6 +105,7 @@ elseif ($Operation -eq 'Get')`
`105`	`105`	`$first = $true`
`106`	`106`	`foreach ($property in $r.properties.psobject.properties)`
`107`	`107`	`{`
	`108`	`+ # TODO: validate property against the CIM class to give better error message`
`108`	`109`	`if ($null -ne $property.value)`
`109`	`110`	`{`
`110`	`111`	`$useWhere = $true`