Skip to content

Commit 953321f

Browse files
committed
Fix tests
1 parent 3bf5eef commit 953321f

File tree

4 files changed

+51
-70
lines changed

4 files changed

+51
-70
lines changed

dsc_lib/src/functions/greater.rs

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -52,26 +52,25 @@ impl Function for Greater {
5252
mod tests {
5353
use crate::configure::context::Context;
5454
use crate::parser::Statement;
55-
use serde_json::Value;
5655

5756
#[test]
5857
fn number_greater() {
5958
let mut parser = Statement::new().unwrap();
6059
let result = parser.parse_and_execute("[greater(2,1)]", &Context::new()).unwrap();
61-
assert_eq!(result, Value::Bool(true));
60+
assert_eq!(result, true);
6261
}
6362

6463
#[test]
6564
fn number_not_greater() {
6665
let mut parser = Statement::new().unwrap();
6766
let result = parser.parse_and_execute("[greater(1,2)]", &Context::new()).unwrap();
68-
assert_eq!(result, Value::Bool(false));
67+
assert_eq!(result, false);
6968
}
7069

7170
#[test]
7271
fn number_equal() {
7372
let mut parser = Statement::new().unwrap();
7473
let result = parser.parse_and_execute("[greater(1,1)]", &Context::new()).unwrap();
75-
assert_eq!(result, Value::Bool(false));
74+
assert_eq!(result, false);
7675
}
7776
}

dsc_lib/src/functions/greater_or_equals.rs

Lines changed: 16 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -51,33 +51,27 @@ impl Function for GreaterOrEquals {
5151

5252
#[cfg(test)]
5353
mod tests {
54-
use super::*;
5554
use crate::configure::context::Context;
55+
use crate::parser::Statement;
5656

5757
#[test]
58-
fn test_greater_or_equals() {
59-
let greater_or_equals = GreaterOrEquals {};
60-
let context = Context::new().unwrap();
61-
62-
let result = greater_or_equals.invoke(&[Value::Number(5.into()), Value::Number(3.into())], &context);
63-
assert!(result.is_ok());
64-
assert_eq!(result.unwrap(), Value::Bool(true));
65-
66-
let result = greater_or_equals.invoke(&[Value::Number(3.into()), Value::Number(5.into())], &context);
67-
assert!(result.is_ok());
68-
assert_eq!(result.unwrap(), Value::Bool(false));
69-
70-
let result = greater_or_equals.invoke(&[Value::Number(5.into()), Value::Number(5.into())], &context);
71-
assert!(result.is_ok());
72-
assert_eq!(result.unwrap(), Value::Bool(true));
58+
fn number_greater_or_equals() {
59+
let mut parser = Statement::new().unwrap();
60+
let result = parser.parse_and_execute("[greaterOrEquals(5,3)]", &Context::new()).unwrap();
61+
assert_eq!(result, true);
7362
}
7463

7564
#[test]
76-
fn test_invalid_args() {
77-
let greater_or_equals = GreaterOrEquals {};
78-
let context = Context::new().unwrap();
79-
80-
let result = greater_or_equals.invoke(&[Value::Number(5.into())], &context);
81-
assert!(result.is_err());
65+
fn number_not_greater_or_equals() {
66+
let mut parser = Statement::new().unwrap();
67+
let result = parser.parse_and_execute("[greaterOrEquals(3,5)]", &Context::new()).unwrap();
68+
assert_eq!(result, false);
69+
}
70+
71+
#[test]
72+
fn number_equal() {
73+
let mut parser = Statement::new().unwrap();
74+
let result = parser.parse_and_execute("[greaterOrEquals(5,5)]", &Context::new()).unwrap();
75+
assert_eq!(result, true);
8276
}
8377
}

dsc_lib/src/functions/less.rs

Lines changed: 16 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -51,33 +51,27 @@ impl Function for Less {
5151

5252
#[cfg(test)]
5353
mod tests {
54-
use super::*;
5554
use crate::configure::context::Context;
55+
use crate::parser::Statement;
5656

5757
#[test]
58-
fn test_less() {
59-
let less = Less {};
60-
let context = Context::new().unwrap();
61-
62-
let result = less.invoke(&[Value::Number(3.into()), Value::Number(5.into())], &context);
63-
assert!(result.is_ok());
64-
assert_eq!(result.unwrap(), Value::Bool(true));
65-
66-
let result = less.invoke(&[Value::Number(5.into()), Value::Number(3.into())], &context);
67-
assert!(result.is_ok());
68-
assert_eq!(result.unwrap(), Value::Bool(false));
69-
70-
let result = less.invoke(&[Value::Number(5.into()), Value::Number(5.into())], &context);
71-
assert!(result.is_ok());
72-
assert_eq!(result.unwrap(), Value::Bool(false));
58+
fn number_less() {
59+
let mut parser = Statement::new().unwrap();
60+
let result = parser.parse_and_execute("[less(3,5)]", &Context::new()).unwrap();
61+
assert_eq!(result, true);
7362
}
7463

7564
#[test]
76-
fn test_invalid_args() {
77-
let less = Less {};
78-
let context = Context::new().unwrap();
79-
80-
let result = less.invoke(&[Value::Number(5.into())], &context);
81-
assert!(result.is_err());
65+
fn number_not_less() {
66+
let mut parser = Statement::new().unwrap();
67+
let result = parser.parse_and_execute("[less(5,3)]", &Context::new()).unwrap();
68+
assert_eq!(result, false);
69+
}
70+
71+
#[test]
72+
fn number_equal() {
73+
let mut parser = Statement::new().unwrap();
74+
let result = parser.parse_and_execute("[less(5,5)]", &Context::new()).unwrap();
75+
assert_eq!(result, false);
8276
}
8377
}

dsc_lib/src/functions/less_or_equals.rs

Lines changed: 16 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -51,33 +51,27 @@ impl Function for LessOrEquals {
5151

5252
#[cfg(test)]
5353
mod tests {
54-
use super::*;
5554
use crate::configure::context::Context;
55+
use crate::parser::Statement;
5656

5757
#[test]
58-
fn test_less_or_equals() {
59-
let less_or_equals = LessOrEquals {};
60-
let context = Context::new().unwrap();
61-
62-
let result = less_or_equals.invoke(&[Value::Number(3.into()), Value::Number(5.into())], &context);
63-
assert!(result.is_ok());
64-
assert_eq!(result.unwrap(), Value::Bool(true));
65-
66-
let result = less_or_equals.invoke(&[Value::Number(5.into()), Value::Number(3.into())], &context);
67-
assert!(result.is_ok());
68-
assert_eq!(result.unwrap(), Value::Bool(false));
69-
70-
let result = less_or_equals.invoke(&[Value::Number(5.into()), Value::Number(5.into())], &context);
71-
assert!(result.is_ok());
72-
assert_eq!(result.unwrap(), Value::Bool(true));
58+
fn number_less_or_equals() {
59+
let mut parser = Statement::new().unwrap();
60+
let result = parser.parse_and_execute("[lessOrEquals(3,5)]", &Context::new()).unwrap();
61+
assert_eq!(result, true);
7362
}
7463

7564
#[test]
76-
fn test_invalid_args() {
77-
let less_or_equals = LessOrEquals {};
78-
let context = Context::new().unwrap();
79-
80-
let result = less_or_equals.invoke(&[Value::Number(5.into())], &context);
81-
assert!(result.is_err());
65+
fn number_not_less_or_equals() {
66+
let mut parser = Statement::new().unwrap();
67+
let result = parser.parse_and_execute("[lessOrEquals(5,3)]", &Context::new()).unwrap();
68+
assert_eq!(result, false);
69+
}
70+
71+
#[test]
72+
fn number_equal() {
73+
let mut parser = Statement::new().unwrap();
74+
let result = parser.parse_and_execute("[lessOrEquals(5,5)]", &Context::new()).unwrap();
75+
assert_eq!(result, true);
8276
}
8377
}

0 commit comments

Comments
 (0)