Ensure Protobuf is available in build

Author: andyleejordan

.pipelines/DSC-Official.yml

@@ -321,7 +321,7 @@ extends:
             ob_restore_phase: true
         - pwsh: |
             apt update
-            apt -y install musl-tools rpm dpkg build-essential
+            apt -y install musl-tools rpm dpkg build-essential protobuf-compiler
             $header = "Bearer $(AzToken)"
             $env:CARGO_REGISTRIES_POWERSHELL_TOKEN = $header
             $env:CARGO_REGISTRIES_POWERSHELL_CREDENTIAL_PROVIDER = 'cargo:token'
@@ -381,6 +381,7 @@ extends:
             apt -y install rpm
             apt -y install dpkg
             apt -y install build-essential
+            apt install -y protobuf-compiler
             msrustup default stable-aarch64-unknown-linux-musl
             if ((openssl version -d) -match 'OPENSSLDIR: "(?<dir>.*?)"') {
               $env:OPENSSL_LIB_DIR = $matches['dir']

build.helpers.psm1

@@ -611,7 +611,6 @@ function Install-NodeJS {
             }
         } elseif ($IsWindows) {
             if (Get-Command 'winget' -ErrorAction Ignore) {
-                Write-Warning "WHY WHAT IS HAPPENING HERE"
                 Write-Verbose -Verbose "Using winget to install Node.js"
                 winget install OpenJS.NodeJS --accept-source-agreements --accept-package-agreements --source winget --silent
             } else {
@@ -627,6 +626,50 @@ function Install-NodeJS {
     }
 }
 
+function Install-Protobuf {
+    <#
+        .SYNOPSIS
+        Installs Protobuf for the protoc executable.
+    #>
+
+    [cmdletbinding()]
+    param()
+
+    process {
+        if ((Get-Command 'protoc' -ErrorAction Ignore)) {
+            Write-Verbose "Protobuf already installed."
+            return
+        }
+
+        Write-Verbose -Verbose "Protobuf not found, installing..."
+        if ($IsMacOS) {
+            if (Get-Command 'brew' -ErrorAction Ignore) {
+                brew install protobuf
+            } else {
+                Write-Warning "Homebrew not found, please install Protobuf manually"
+            }
+        } elseif ($IsWindows) {
+            if (Get-Command 'winget' -ErrorAction Ignore) {
+                Write-Verbose -Verbose "Using winget to install Protobuf"
+                winget install Google.Protobuf --accept-source-agreements --accept-package-agreements --source winget --silent
+            } else {
+                Write-Warning "winget not found, please install Protobuf manually"
+            }
+        } else {
+            if (Get-Command 'apt' -ErrorAction Ignore) {
+                Write-Verbose -Verbose "Using apt to install Protobuf"
+                sudo apt install -y protobuf-compiler
+            } else {
+                Write-Warning "apt not found, please install Protobuf manually"
+            }
+        }
+
+        if ($LASTEXITCODE -ne 0) {
+            throw "Failed to install Protobuf"
+        }
+    }
+}
+
 function Install-PowerShellTestPrerequisite {
     [cmdletbinding()]
     param(

build.ps1

@@ -203,13 +203,14 @@ process {
         }
 
         if (-not ($SkipBuild -and $Test -and $ExcludeRustTests)) {
-            # Install Node if needed
             Write-BuildProgress @progressParams -Status 'Ensuring Node.JS is available'
             Install-NodeJS @VerboseParam
-    
-            # Ensure tree-sitter is installed
+
             Write-BuildProgress @progressParams -Status 'Ensuring tree-sitter is available'
             Install-TreeSitter -UseCFS:$UseCFS @VerboseParam
+
+            Write-BuildProgress @progressParams -Status 'Ensuring Protobuf is available'
+            Install-Protobuf @VerboseParam
         }
     }
 
@@ -259,7 +260,7 @@ process {
     if ($Test) {
         $progressParams.Activity = 'Testing projects'
         Write-BuildProgress @progressParams
-        
+
         if (-not $ExcludeRustTests) {
             $rustTestParams = @{
                 Project      = $BuildData.Projects
@@ -319,4 +320,4 @@ clean {
     }
 
     Write-BuildProgress -Completed
-}
+}

dscbicep/build.rs

@@ -9,8 +9,6 @@ fn main() -> Result<(), Box<dyn std::error::Error>> {
     tonic_prost_build::configure()
         .build_client(false)
         .file_descriptor_set_path(&descriptor_path)
-        // TODO: Configure and commit the out_dir to avoid dependency on protoc
-        // .out_dir(out_dir)
         .compile_protos(&["proto/bicep.proto"], &["proto"])?;
     Ok(())
 }