Add support for using get if resource doesn't implement export
#1035
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR enables exporting configurations for resources that only implement get when they don't implement export. The change removes the redundant export implementation from OSInfo resource and adds a new Test/Get resource to validate the fallback behavior.
- Adds fallback logic to use
getwhenexportis not available - Removes redundant
exportimplementation from OSInfo resource - Adds new Test/Get resource for testing get-only scenarios
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| dsc_lib/src/dscresources/command_resource.rs | Implements fallback logic to use get when export is unavailable |
| osinfo/osinfo.dsc.resource.json | Removes redundant export implementation |
| tools/dsctest/src/get.rs | Adds new Get struct for test resource |
| tools/dsctest/src/main.rs | Implements Get subcommand and schema handling |
| tools/dsctest/src/args.rs | Adds Get command line arguments |
| tools/dsctest/dscget.dsc.resource.json | Adds Test/Get resource manifest |
| dsc/tests/dsc_export.tests.ps1 | Adds tests for export fallback scenarios |
tgauth
reviewed
Aug 13, 2025
SteveL-MSFT
force-pushed
the
get-as-export
branch
from
1e5c8cb to
43d58cc
Compare
tgauth
approved these changes
Aug 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Enable exporting a configuration that specifies resources that only implement
get. This change also makes theOSInforesource only implementget(sinceexportliterally did the same operation). Added a new test resource to help validate the case where input is provided as a filter and where none is provided.PR Context
Fix #428