Enable rustfmt in repo and fix current formatting #1165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It also seems within the Rust community that rustfmt isn't being actively maintained |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Add
rustfmtunder-clippy. There is a new-FmtFixswitch forbuild.ps1to automatically make formatting fixes, otherwise, CI will fail if rustfmt checks fail.Used a slightly modified version of the proposed rustfmt.toml, however, many of the options are only available in the nightly channel and not the stable one. I decided to keep them in the toml but not to use the nightly channel for now (due to being unstable by definition).
All the code changes are just formatting changes. However, due to the formatting changes, some functions became too long so added
#[allow(clippy::too_many_lines)]to some functions for now.Making this a draft for now, the features we need in rustfmt are only available in the nightly toolchain and we don't want to take a dependency on that. Will revisit when the nightly features show up in stable.
PR Context
Fix #1155