Handle 'PSObject' correctly so that script block handlers works for 'AddToHistoryHandler' (#1068)

Author: daxian-dbw

PSReadLine/History.cs

@@ -137,15 +137,32 @@ private AddToHistoryOption GetAddToHistoryOption(string line)
                 }
 
                 object value = Options.AddToHistoryHandler(line);
+                if (value is PSObject psObj)
+                {
+                    value = psObj.BaseObject;
+                }
+
+                if (value is bool boolValue)
+                {
+                    return boolValue ? AddToHistoryOption.MemoryAndFile : AddToHistoryOption.SkipAdding;
+                }
 
-                if (LanguagePrimitives.TryConvertTo(value, out AddToHistoryOption enumValue))
+                if (value is AddToHistoryOption enumValue)
                 {
                     return enumValue;
                 }
 
-                if (value is bool boolValue && !boolValue)
+                if (value is string strValue && Enum.TryParse(strValue, out enumValue))
                 {
-                    return AddToHistoryOption.SkipAdding;
+                    return enumValue;
+                }
+
+                // 'TryConvertTo' incurs exception handling when the value cannot be converted to the target type.
+                // It's expensive, especially when we need to process lots of history items from file during the
+                // initialization. So do the conversion as the last resort.
+                if (LanguagePrimitives.TryConvertTo(value, out enumValue))
+                {
+                    return enumValue;
                 }
             }