Give better uninstall error feedback

Author: cbadke

ChocolateyPackage/tools/Install-Module.ps1

@@ -5,6 +5,8 @@ param(
         [String] $ModuleName
      )
 
+$ErrorActionPreference = "Stop"
+
 if (!(Test-Path -PathType Container $PathToModuleFiles)) {
     Write-Error "$PathToModuleFiles not found or is not a directory. Nothing to install."
     exit

ChocolateyPackage/tools/Remove-Module.ps1

@@ -3,6 +3,9 @@ param(
     [String] $ModuleName
 )
 
+    $ErrorActionPreference = "Stop"
+
+
     $moduleRoot = "$($env:CommonProgramW6432)\Modules\"
     $dir = "$moduleRoot\$ModuleName\"
 

ChocolateyPackage/tools/chocolateyuninstall.ps1

@@ -6,6 +6,16 @@ try {
 
   Write-ChocolateySuccess $packageName
 } catch {
-  Write-ChocolateyFailure $packageName $($_.Exception.Message)
+  $message = @"
+  Uhoh. Looks like $packageName doesn't want to uninstall! But don't worry there is probably a good explanation.
+
+  It is highly likely that you have an instance of PowerShell running with $packageName loaded.
+
+  You should probably try closing all instances of PowerShell and rerunning this uninstall from cmd.exe.
+"@
+
+  Write-Host "==============================================="
+  Write-Host $message
+  Write-Host "==============================================="
   throw
 }