No list view prediction when the first line was scrolled up off the buffer (#3372)

daxian-dbw · web-flow · commit bbbe43bde346 · 2022-07-08T15:32:37.000-07:00
diff --git a/PSReadLine/Prediction.Views.cs b/PSReadLine/Prediction.Views.cs
@@ -275,6 +275,13 @@ internal PredictionListView(PSConsoleReadLine singleton)
 
             internal override void GetSuggestion(string userInput)
             {
+                if (_singleton._initialY < 0)
+                {
+                    // Do not trigger list view prediction when the first line has already been scrolled up off the buffer.
+                    // See https://github.com/PowerShell/PSReadLine/issues/3347 for an example where this may happen.
+                    return;
+                }
+
                 bool inputUnchanged = string.Equals(_inputText, userInput, _singleton._options.HistoryStringComparison);
                 if (!inputUnchanged && _selectedIndex > -1)
                 {

Original file line number	Diff line number	Diff line change
`@@ -275,6 +275,13 @@ internal PredictionListView(PSConsoleReadLine singleton)`
`275`	`275`
`276`	`276`	`internal override void GetSuggestion(string userInput)`
`277`	`277`	`{`
	`278`	`+ if (_singleton._initialY < 0)`
	`279`	`+ {`
	`280`	`+ // Do not trigger list view prediction when the first line has already been scrolled up off the buffer.`
	`281`	`+ // See https://github.com/PowerShell/PSReadLine/issues/3347 for an example where this may happen.`
	`282`	`+ return;`
	`283`	`+ }`
	`284`	`+`
`278`	`285`	`bool inputUnchanged = string.Equals(_inputText, userInput, _singleton._options.HistoryStringComparison);`
`279`	`286`	`if (!inputUnchanged && _selectedIndex > -1)`
`280`	`287`	`{`