Fix requiring 'tags' in server response (#1627)

evelyn-bi · alerickson · commit 0a13812df1cf · 2024-05-09T20:00:16.000-07:00
diff --git a/src/code/V3ServerAPICalls.cs b/src/code/V3ServerAPICalls.cs
@@ -493,7 +493,7 @@ private FindResults FindNameHelper(string packageName, string[] tags, bool inclu
 
                             return new FindResults(stringResponse: Utils.EmptyStrArray, hashtableResponse: emptyHashResponses, responseType: v3FindResponseType);
                         }
-                        if (!rootDom.TryGetProperty(tagsName, out JsonElement tagsItem))
+                        if (!rootDom.TryGetProperty(tagsName, out JsonElement tagsItem) && tags.Length != 0)
                         {
                             errRecord = new ErrorRecord(
                                 new InvalidOrEmptyResponse($"Response does not contain '{tagsName}' element for search with Name '{packageName}' in '{Repository.Name}'."),
@@ -603,7 +603,7 @@ private FindResults FindVersionHelper(string packageName, string version, string
 
                             return new FindResults(stringResponse: Utils.EmptyStrArray, hashtableResponse: emptyHashResponses, responseType: v3FindResponseType);
                         }
-                        if (!rootDom.TryGetProperty(tagsName, out JsonElement tagsItem))
+                        if (!rootDom.TryGetProperty(tagsName, out JsonElement tagsItem) && tags.Length != 0)
                         {
                             errRecord = new ErrorRecord(
                                 new InvalidOrEmptyResponse($"Response does not contain '{tagsName}' element for search with name '{packageName}' and version '{version}' in repository '{Repository.Name}'."),

Original file line number	Diff line number	Diff line change
`@@ -493,7 +493,7 @@ private FindResults FindNameHelper(string packageName, string[] tags, bool inclu`
`493`	`493`
`494`	`494`	`return new FindResults(stringResponse: Utils.EmptyStrArray, hashtableResponse: emptyHashResponses, responseType: v3FindResponseType);`
`495`	`495`	`}`
`496`		`- if (!rootDom.TryGetProperty(tagsName, out JsonElement tagsItem))`
	`496`	`+ if (!rootDom.TryGetProperty(tagsName, out JsonElement tagsItem) && tags.Length != 0)`
`497`	`497`	`{`
`498`	`498`	`errRecord = new ErrorRecord(`
`499`	`499`	`new InvalidOrEmptyResponse($"Response does not contain '{tagsName}' element for search with Name '{packageName}' in '{Repository.Name}'."),`
`@@ -603,7 +603,7 @@ private FindResults FindVersionHelper(string packageName, string version, string`
`603`	`603`
`604`	`604`	`return new FindResults(stringResponse: Utils.EmptyStrArray, hashtableResponse: emptyHashResponses, responseType: v3FindResponseType);`
`605`	`605`	`}`
`606`		`- if (!rootDom.TryGetProperty(tagsName, out JsonElement tagsItem))`
	`606`	`+ if (!rootDom.TryGetProperty(tagsName, out JsonElement tagsItem) && tags.Length != 0)`
`607`	`607`	`{`
`608`	`608`	`errRecord = new ErrorRecord(`
`609`	`609`	`new InvalidOrEmptyResponse($"Response does not contain '{tagsName}' element for search with name '{packageName}' and version '{version}' in repository '{Repository.Name}'."),`