fix my comments

anamnavi · anamnavi · commit 2b372e6c9655 · 2024-12-09T15:26:42.000-05:00
diff --git a/src/code/V2ServerAPICalls.cs b/src/code/V2ServerAPICalls.cs
@@ -913,7 +913,6 @@ private string FindAllFromTypeEndPoint(bool includePrerelease, bool isSearchingM
             }
 
             // JFrog/Artifactory requires an empty search term to enumerate all packages in the feed
-            // It also deems 'IsLatestVersion eq true' and 'IsAbsoluteLatestVersion eq true' in the filter to be a bad request, so we use 'IsLatestVersion' or 'IsAbsoluteLatestVersion' only
             if (_isJFrogRepo) {
                 queryBuilder.SearchTerm = "''";
 
@@ -925,6 +924,7 @@ private string FindAllFromTypeEndPoint(bool includePrerelease, bool isSearchingM
                 }
             }
             else {
+                // For ADO, 'IsLatestVersion eq true' and 'IsAbsoluteLatestVersion eq true' in the filter create a bad request error, so we use 'IsLatestVersion' or 'IsAbsoluteLatestVersion' only
                 if (includePrerelease) {
                     queryBuilder.AdditionalParameters["includePrerelease"] = "true";
                     filterBuilder.AddCriterion("IsAbsoluteLatestVersion");
@@ -962,20 +962,21 @@ private string FindTagFromEndpoint(string[] tags, bool includePrerelease, bool i
                 queryBuilder.AdditionalParameters["$orderby"] = "Id desc";
             }
 
-            // JFrog/Artifactory deems 'IsLatestVersion eq true' and 'IsAbsoluteLatestVersion eq true' in the filter to be a bad request, so we use 'IsLatestVersion' or 'IsAbsoluteLatestVersion' only
             if (includePrerelease) {
                 queryBuilder.AdditionalParameters["includePrerelease"] = "true";
                 if (_isJFrogRepo) {
                     filterBuilder.AddCriterion("IsAbsoluteLatestVersion eq true");
                 }
                 else {
+                    // For ADO, 'IsLatestVersion eq true' and 'IsAbsoluteLatestVersion eq true' in the filter create a bad request error, so we use 'IsLatestVersion' or 'IsAbsoluteLatestVersion' only
                     filterBuilder.AddCriterion("IsAbsoluteLatestVersion");
                 }
             } else {
                 if (_isJFrogRepo) {
                     filterBuilder.AddCriterion("IsLatestVersion eq true");
                 }
                 else {
+                    // For ADO, 'IsLatestVersion eq true' and 'IsAbsoluteLatestVersion eq true' in the filter create a bad request error, so we use 'IsLatestVersion' or 'IsAbsoluteLatestVersion' only
                     filterBuilder.AddCriterion("IsLatestVersion");
                 }
             }
@@ -1010,20 +1011,21 @@ private string FindCommandOrDscResource(string[] tags, bool includePrerelease, b
                 queryBuilder.AdditionalParameters["$orderby"] = "Id desc";
             }
 
-            // JFrog/Artifactory deems 'IsLatestVersion eq true' and 'IsAbsoluteLatestVersion eq true' in the filter to be a bad request, so we use 'IsLatestVersion' or 'IsAbsoluteLatestVersion' only
             if (includePrerelease) {
                 queryBuilder.AdditionalParameters["includePrerelease"] = "true";
                 if (_isJFrogRepo) {
                     filterBuilder.AddCriterion("IsAbsoluteLatestVersion eq true");
                 }
                 else {
+                    // For ADO, 'IsLatestVersion eq true' and 'IsAbsoluteLatestVersion eq true' in the filter create a bad request error, so we use 'IsLatestVersion' or 'IsAbsoluteLatestVersion' only
                     filterBuilder.AddCriterion("IsAbsoluteLatestVersion");
                 }
             } else {
                 if (_isJFrogRepo) {
                     filterBuilder.AddCriterion("IsLatestVersion eq true");
                 }
                 else {
+                    // For ADO, 'IsLatestVersion eq true' and 'IsAbsoluteLatestVersion eq true' in the filter create a bad request error, so we use 'IsLatestVersion' or 'IsAbsoluteLatestVersion' only
                     filterBuilder.AddCriterion("IsLatestVersion");
                 }
             }
@@ -1062,20 +1064,21 @@ private string FindNameGlobbing(string packageName, ResourceType type, bool incl
                 queryBuilder.AdditionalParameters["$orderby"] = "Id desc";
             }
 
-            // It also deems 'IsLatestVersion eq true' and 'IsAbsoluteLatestVersion eq true' in the filter to be a bad request, so we use 'IsLatestVersion' or 'IsAbsoluteLatestVersion' only
             if (includePrerelease) {
                 queryBuilder.AdditionalParameters["includePrerelease"] = "true";
                 if (_isJFrogRepo) {
                     filterBuilder.AddCriterion("IsAbsoluteLatestVersion eq true");
                 }
                 else {
+                    // For ADO, 'IsLatestVersion eq true' and 'IsAbsoluteLatestVersion eq true' in the filter create a bad request error, so we use 'IsLatestVersion' or 'IsAbsoluteLatestVersion' only
                     filterBuilder.AddCriterion("IsAbsoluteLatestVersion");
                 }
             } else {
                 if (_isJFrogRepo) {
                     filterBuilder.AddCriterion("IsLatestVersion eq true");
                 }
                 else {
+                    // For ADO, 'IsLatestVersion eq true' and 'IsAbsoluteLatestVersion eq true' in the filter create a bad request error, so we use 'IsLatestVersion' or 'IsAbsoluteLatestVersion' only
                     filterBuilder.AddCriterion("IsLatestVersion");
                 }
             }
@@ -1168,20 +1171,21 @@ private string FindNameGlobbingWithTag(string packageName, string[] tags, Resour
             }
 
             // JFrog/Artifactory requires an empty search term to enumerate all packages in the feed
-            // It also deems 'IsLatestVersion eq true' and 'IsAbsoluteLatestVersion eq true' in the filter to be a bad request, so we use 'IsLatestVersion' or 'IsAbsoluteLatestVersion' only
             if (includePrerelease) {
                 queryBuilder.AdditionalParameters["includePrerelease"] = "true";
                 if (_isJFrogRepo) {
                     filterBuilder.AddCriterion("IsAbsoluteLatestVersion eq true");
                 }
                 else {
+                    // For ADO, 'IsLatestVersion eq true' and 'IsAbsoluteLatestVersion eq true' in the filter create a bad request error, so we use 'IsLatestVersion' or 'IsAbsoluteLatestVersion' only
                     filterBuilder.AddCriterion("IsAbsoluteLatestVersion");
                 }
             } else {
                 if (_isJFrogRepo) {
                     filterBuilder.AddCriterion("IsLatestVersion eq true");
                 }
                 else {
+                    // For ADO, 'IsLatestVersion eq true' and 'IsAbsoluteLatestVersion eq true' in the filter create a bad request error, so we use 'IsLatestVersion' or 'IsAbsoluteLatestVersion' only
                     filterBuilder.AddCriterion("IsLatestVersion");
                 }
             }

Original file line number	Diff line number	Diff line change
`@@ -913,7 +913,6 @@ private string FindAllFromTypeEndPoint(bool includePrerelease, bool isSearchingM`
`913`	`913`	`}`
`914`	`914`
`915`	`915`	`// JFrog/Artifactory requires an empty search term to enumerate all packages in the feed`
`916`		`- // It also deems 'IsLatestVersion eq true' and 'IsAbsoluteLatestVersion eq true' in the filter to be a bad request, so we use 'IsLatestVersion' or 'IsAbsoluteLatestVersion' only`
`917`	`916`	`if (_isJFrogRepo) {`
`918`	`917`	`queryBuilder.SearchTerm = "''";`
`919`	`918`
`@@ -925,6 +924,7 @@ private string FindAllFromTypeEndPoint(bool includePrerelease, bool isSearchingM`
`925`	`924`	`}`
`926`	`925`	`}`
`927`	`926`	`else {`
	`927`	`+ // For ADO, 'IsLatestVersion eq true' and 'IsAbsoluteLatestVersion eq true' in the filter create a bad request error, so we use 'IsLatestVersion' or 'IsAbsoluteLatestVersion' only`
`928`	`928`	`if (includePrerelease) {`
`929`	`929`	`queryBuilder.AdditionalParameters["includePrerelease"] = "true";`
`930`	`930`	`filterBuilder.AddCriterion("IsAbsoluteLatestVersion");`
`@@ -962,20 +962,21 @@ private string FindTagFromEndpoint(string[] tags, bool includePrerelease, bool i`
`962`	`962`	`queryBuilder.AdditionalParameters["$orderby"] = "Id desc";`
`963`	`963`	`}`
`964`	`964`
`965`		`- // JFrog/Artifactory deems 'IsLatestVersion eq true' and 'IsAbsoluteLatestVersion eq true' in the filter to be a bad request, so we use 'IsLatestVersion' or 'IsAbsoluteLatestVersion' only`
`966`	`965`	`if (includePrerelease) {`
`967`	`966`	`queryBuilder.AdditionalParameters["includePrerelease"] = "true";`
`968`	`967`	`if (_isJFrogRepo) {`
`969`	`968`	`filterBuilder.AddCriterion("IsAbsoluteLatestVersion eq true");`
`970`	`969`	`}`
`971`	`970`	`else {`
	`971`	`+ // For ADO, 'IsLatestVersion eq true' and 'IsAbsoluteLatestVersion eq true' in the filter create a bad request error, so we use 'IsLatestVersion' or 'IsAbsoluteLatestVersion' only`
`972`	`972`	`filterBuilder.AddCriterion("IsAbsoluteLatestVersion");`
`973`	`973`	`}`
`974`	`974`	`} else {`
`975`	`975`	`if (_isJFrogRepo) {`
`976`	`976`	`filterBuilder.AddCriterion("IsLatestVersion eq true");`
`977`	`977`	`}`
`978`	`978`	`else {`
	`979`	`+ // For ADO, 'IsLatestVersion eq true' and 'IsAbsoluteLatestVersion eq true' in the filter create a bad request error, so we use 'IsLatestVersion' or 'IsAbsoluteLatestVersion' only`
`979`	`980`	`filterBuilder.AddCriterion("IsLatestVersion");`
`980`	`981`	`}`
`981`	`982`	`}`
`@@ -1010,20 +1011,21 @@ private string FindCommandOrDscResource(string[] tags, bool includePrerelease, b`
`1010`	`1011`	`queryBuilder.AdditionalParameters["$orderby"] = "Id desc";`
`1011`	`1012`	`}`
`1012`	`1013`
`1013`		`- // JFrog/Artifactory deems 'IsLatestVersion eq true' and 'IsAbsoluteLatestVersion eq true' in the filter to be a bad request, so we use 'IsLatestVersion' or 'IsAbsoluteLatestVersion' only`
`1014`	`1014`	`if (includePrerelease) {`
`1015`	`1015`	`queryBuilder.AdditionalParameters["includePrerelease"] = "true";`
`1016`	`1016`	`if (_isJFrogRepo) {`
`1017`	`1017`	`filterBuilder.AddCriterion("IsAbsoluteLatestVersion eq true");`
`1018`	`1018`	`}`
`1019`	`1019`	`else {`
	`1020`	`+ // For ADO, 'IsLatestVersion eq true' and 'IsAbsoluteLatestVersion eq true' in the filter create a bad request error, so we use 'IsLatestVersion' or 'IsAbsoluteLatestVersion' only`
`1020`	`1021`	`filterBuilder.AddCriterion("IsAbsoluteLatestVersion");`
`1021`	`1022`	`}`
`1022`	`1023`	`} else {`
`1023`	`1024`	`if (_isJFrogRepo) {`
`1024`	`1025`	`filterBuilder.AddCriterion("IsLatestVersion eq true");`
`1025`	`1026`	`}`
`1026`	`1027`	`else {`
	`1028`	`+ // For ADO, 'IsLatestVersion eq true' and 'IsAbsoluteLatestVersion eq true' in the filter create a bad request error, so we use 'IsLatestVersion' or 'IsAbsoluteLatestVersion' only`
`1027`	`1029`	`filterBuilder.AddCriterion("IsLatestVersion");`
`1028`	`1030`	`}`
`1029`	`1031`	`}`
`@@ -1062,20 +1064,21 @@ private string FindNameGlobbing(string packageName, ResourceType type, bool incl`
`1062`	`1064`	`queryBuilder.AdditionalParameters["$orderby"] = "Id desc";`
`1063`	`1065`	`}`
`1064`	`1066`
`1065`		`- // It also deems 'IsLatestVersion eq true' and 'IsAbsoluteLatestVersion eq true' in the filter to be a bad request, so we use 'IsLatestVersion' or 'IsAbsoluteLatestVersion' only`
`1066`	`1067`	`if (includePrerelease) {`
`1067`	`1068`	`queryBuilder.AdditionalParameters["includePrerelease"] = "true";`
`1068`	`1069`	`if (_isJFrogRepo) {`
`1069`	`1070`	`filterBuilder.AddCriterion("IsAbsoluteLatestVersion eq true");`
`1070`	`1071`	`}`
`1071`	`1072`	`else {`
	`1073`	`+ // For ADO, 'IsLatestVersion eq true' and 'IsAbsoluteLatestVersion eq true' in the filter create a bad request error, so we use 'IsLatestVersion' or 'IsAbsoluteLatestVersion' only`
`1072`	`1074`	`filterBuilder.AddCriterion("IsAbsoluteLatestVersion");`
`1073`	`1075`	`}`
`1074`	`1076`	`} else {`
`1075`	`1077`	`if (_isJFrogRepo) {`
`1076`	`1078`	`filterBuilder.AddCriterion("IsLatestVersion eq true");`
`1077`	`1079`	`}`
`1078`	`1080`	`else {`
	`1081`	`+ // For ADO, 'IsLatestVersion eq true' and 'IsAbsoluteLatestVersion eq true' in the filter create a bad request error, so we use 'IsLatestVersion' or 'IsAbsoluteLatestVersion' only`
`1079`	`1082`	`filterBuilder.AddCriterion("IsLatestVersion");`
`1080`	`1083`	`}`
`1081`	`1084`	`}`
`@@ -1168,20 +1171,21 @@ private string FindNameGlobbingWithTag(string packageName, string[] tags, Resour`
`1168`	`1171`	`}`
`1169`	`1172`
`1170`	`1173`	`// JFrog/Artifactory requires an empty search term to enumerate all packages in the feed`
`1171`		`- // It also deems 'IsLatestVersion eq true' and 'IsAbsoluteLatestVersion eq true' in the filter to be a bad request, so we use 'IsLatestVersion' or 'IsAbsoluteLatestVersion' only`
`1172`	`1174`	`if (includePrerelease) {`
`1173`	`1175`	`queryBuilder.AdditionalParameters["includePrerelease"] = "true";`
`1174`	`1176`	`if (_isJFrogRepo) {`
`1175`	`1177`	`filterBuilder.AddCriterion("IsAbsoluteLatestVersion eq true");`
`1176`	`1178`	`}`
`1177`	`1179`	`else {`
	`1180`	`+ // For ADO, 'IsLatestVersion eq true' and 'IsAbsoluteLatestVersion eq true' in the filter create a bad request error, so we use 'IsLatestVersion' or 'IsAbsoluteLatestVersion' only`
`1178`	`1181`	`filterBuilder.AddCriterion("IsAbsoluteLatestVersion");`
`1179`	`1182`	`}`
`1180`	`1183`	`} else {`
`1181`	`1184`	`if (_isJFrogRepo) {`
`1182`	`1185`	`filterBuilder.AddCriterion("IsLatestVersion eq true");`
`1183`	`1186`	`}`
`1184`	`1187`	`else {`
	`1188`	`+ // For ADO, 'IsLatestVersion eq true' and 'IsAbsoluteLatestVersion eq true' in the filter create a bad request error, so we use 'IsLatestVersion' or 'IsAbsoluteLatestVersion' only`
`1185`	`1189`	`filterBuilder.AddCriterion("IsLatestVersion");`
`1186`	`1190`	`}`
`1187`	`1191`	`}`