Add tests for Group Policy Enforcement

Author: adityapatwardhan

src/code/GroupPolicyRepositoryEnforcement.cs

@@ -6,6 +6,7 @@
 using System;
 using System.Collections.Generic;
 using System.Linq;
+using Microsoft.PowerShell.PSResourceGet.UtilClasses;
 using Microsoft.Win32;
 
 namespace Microsoft.PowerShell.PSResourceGet.Cmdlets
@@ -35,6 +36,11 @@ public static bool IsGroupPolicyEnabled()
                 throw new PlatformNotSupportedException("Group policy is only supported on Windows.");
             }
 
+            if (InternalHooks.EnableGPRegistryHook)
+            {
+                return InternalHooks.GPEnabledStatus;
+            }
+
             var values = ReadGPFromRegistry();
 
             if (values is not null && values.Count > 0)
@@ -57,6 +63,12 @@ public static bool IsGroupPolicyEnabled()
                 throw new PlatformNotSupportedException("Group policy is only supported on Windows.");
             }
 
+            if (InternalHooks.EnableGPRegistryHook)
+            {
+                var uri = new Uri(InternalHooks.AllowedUri);
+                return new Uri[] { uri };
+            }
+
             if (!IsGroupPolicyEnabled())
             {
                 throw new InvalidOperationException("Group policy is not enabled.");

src/code/InternalHooks.cs

@@ -9,6 +9,12 @@ public class InternalHooks
     {
         internal static bool InvokedFromCompat;
 
+        internal static bool EnableGPRegistryHook;
+
+        internal static bool GPEnabledStatus;
+
+        internal static string AllowedUri;
+
         public static void SetTestHook(string property, object value)
         {
             var fieldInfo = typeof(InternalHooks).GetField(property, BindingFlags.Static | BindingFlags.NonPublic);

test/GroupPolicyEnforcement.Tests.ps1

@@ -4,42 +4,102 @@
 
 # Add Pester test to check the API for GroupPolicyEnforcement
 
-Describe 'GroupPolicyEnforcement API Tests' {
-    BeforeAll {
-        # Setup code if needed
+Describe 'GroupPolicyEnforcement API Tests' -Tags 'CI' {
+
+    It 'Should return the correct policy enforcement status' -Skip:(-not $IsWindows) {
+        $actualStatus = [Microsoft.PowerShell.PSResourceGet.Cmdlets.GroupPolicyRepositoryEnforcement]::IsGroupPolicyEnabled()
+        $actualStatus | Should -Be $false
     }
 
-    AfterAll {
-        # Cleanup code if needed
+    It 'Should return platform not supported exception on non-windows platform' -Skip:$IsWindows {
+        try {
+            [Microsoft.PowerShell.PSResourceGet.Cmdlets.GroupPolicyRepositoryEnforcement]::IsGroupPolicyEnabled()
+        }
+        catch {
+            $_.Exception.Message | Should -Be 'Group Policy is not supported on this platform.'
+            $_.Exception.InnerException.GetType().FullName | Should -Be 'System.InvalidOperationException'
+        }
     }
 
-    It 'Should return the correct policy enforcement status' {
+    It 'Group Policy must be enabled before getting allowed repositories' -Skip:(-not $IsWindows) {
+        try {
+            [Microsoft.PowerShell.PSResourceGet.Cmdlets.GroupPolicyRepositoryEnforcement]::GetAllowedRepositoryURIs()
+        }
+        catch {
+            $_.Exception.InnerException.Message | Should -Be 'Group policy is not enabled.'
+        }
+    }
+}
+
+Describe 'GroupPolicyEnforcement Cmdlet Tests' -Tags 'CI' {
+    BeforeEach {
+        [Microsoft.PowerShell.PSResourceGet.UtilClasses.InternalHooks]::SetTestHook('EnableGPRegistryHook', $true)
+        [Microsoft.PowerShell.PSResourceGet.UtilClasses.InternalHooks]::SetTestHook('GPEnabledStatus', $true)
+        [Microsoft.PowerShell.PSResourceGet.UtilClasses.InternalHooks]::SetTestHook('AllowedUri', "https://www.example.com/")
+    }
+
+    AfterEach {
+        [Microsoft.PowerShell.PSResourceGet.UtilClasses.InternalHooks]::SetTestHook('EnableGPRegistryHook', $false)
+        [Microsoft.PowerShell.PSResourceGet.UtilClasses.InternalHooks]::SetTestHook('GPEnabledStatus', $false)
+        [Microsoft.PowerShell.PSResourceGet.UtilClasses.InternalHooks]::SetTestHook('AllowedUri', $null)
+    }
+
+    It 'Getting allowed repositories works as expected' -Skip:(-not $IsWindows) {
+        $allowedReps = [Microsoft.PowerShell.PSResourceGet.Cmdlets.GroupPolicyRepositoryEnforcement]::GetAllowedRepositoryURIs()
+        $allowedReps.AbsoluteUri | Should -Be @("https://www.example.com/")
+    }
 
+    It 'Get-PSResourceRepository lists the allowed repository' -Skip:(-not $IsWindows) {
         try {
-            $expectedStatus = 'Disabled'
-            $actualStatus = [Microsoft.PowerShell.PSResourceGet.Cmdlets.GroupPolicyRepositoryEnforcement]::IsGroupPolicyEnabled()
-            $actualStatus | Should -Be $expectedStatus
+            Register-PSResourceRepository -Name 'Example' -Uri 'https://www.example.com/'
+            $psrep = Get-PSResourceRepository -Name 'Example'
+            $psrep | Should -Not -BeNullOrEmpty
+            $psrep.IsAllowedByPolicy | Should -Be $true
         }
         finally {
-
+            Unregister-PSResourceRepository -Name 'Example'
         }
+    }
+
+    It 'Find-PSResource is blocked by policy' -Skip:(-not $IsWindows) {
+        try {
+            Register-PSResourceRepository -Name 'Example' -Uri 'https://www.example.com/' -ApiVersion 'v3'
+            { Find-PSResource -Repository PSGallery -Name 'Az.Accounts' -ErrorAction Stop } | Should -Throw "Repository 'PSGallery' is not allowed by Group Policy."
 
+            # Allow PSGallery and it should not fail
+            [Microsoft.PowerShell.PSResourceGet.UtilClasses.InternalHooks]::SetTestHook('AllowedUri', " https://www.powershellgallery.com/api/v2")
+            { Find-PSResource -Repository PSGallery -Name 'Az.Accounts' -ErrorAction Stop } | Should -Not -Throw
+        }
+        finally {
+            Unregister-PSResourceRepository -Name 'Example'
+        }
     }
 
-    It 'Should throw an error for invalid policy name' {
-        # Arrange
-        $invalidPolicyName = 'InvalidPolicy'
+    It 'Install-PSResource is blocked by policy' -Skip:(-not $IsWindows) {
+        try {
+            Register-PSResourceRepository -Name 'Example' -Uri 'https://www.example.com/' -ApiVersion 'v3'
+            { Find-PSResource -Repository PSGallery -Name 'Az.Accounts' -ErrorAction Stop } | Should -Throw "Repository 'PSGallery' is not allowed by Group Policy."
 
-        # Act & Assert
-        { Get-GroupPolicyEnforcementStatus -PolicyName $invalidPolicyName } | Should -Throw
+            # Allow PSGallery and it should not fail
+            [Microsoft.PowerShell.PSResourceGet.UtilClasses.InternalHooks]::SetTestHook('AllowedUri', " https://www.powershellgallery.com/api/v2")
+            { Find-PSResource -Repository PSGallery -Name 'Az.Accounts' -ErrorAction Stop } | Should -Not -Throw
+        }
+        finally {
+            Unregister-PSResourceRepository -Name 'Example'
+        }
     }
 
-    It 'Should return a list of all enforced policies' {
-        # Act
-        $policies = Get-AllEnforcedPolicies
+    It 'Save-PSResource is blocked by policy' -Skip:(-not $IsWindows) {
+        try {
+            Register-PSResourceRepository -Name 'Example' -Uri 'https://www.example.com/' -ApiVersion 'v3'
+            { Find-PSResource -Repository PSGallery -Name 'Az.Accounts' -ErrorAction Stop } | Should -Throw "Repository 'PSGallery' is not allowed by Group Policy."
 
-        # Assert
-        $policies | Should -Not -BeNullOrEmpty
-        $policies | Should -BeOfType 'System.Collections.Generic.List[System.String]'
+            # Allow PSGallery and it should not fail
+            [Microsoft.PowerShell.PSResourceGet.UtilClasses.InternalHooks]::SetTestHook('AllowedUri', " https://www.powershellgallery.com/api/v2")
+            { Find-PSResource -Repository PSGallery -Name 'Az.Accounts' -ErrorAction Stop } | Should -Not -Throw
+        }
+        finally {
+            Unregister-PSResourceRepository -Name 'Example'
+        }
     }
 }