Check for ModulePrefix parameter presence instead of it being a dynamic parameter

Author: anamnavi

src/code/PublishPSResource.cs

@@ -17,13 +17,12 @@ namespace Microsoft.PowerShell.PSResourceGet.Cmdlets
         "PSResource",
         SupportsShouldProcess = true)]
     [Alias("pbres")]
-    public sealed class PublishPSResource : PSCmdlet, IDynamicParameters
+    public sealed class PublishPSResource : PSCmdlet
     {
         #region Parameters
 
         private const string PathParameterSet = "PathParameterSet";
         private const string NupkgPathParameterSet = "NupkgPathParameterSet";
-        private ContainerRegistryDynamicParameters _pkgPrefix;
 
         /// <summary>
         /// Specifies the API key that you want to use to publish a module to the online gallery.
@@ -117,20 +116,12 @@ public PSCredential ProxyCredential {
         [ValidateNotNullOrEmpty]
         public string NupkgPath { get; set; }
 
-        #endregion
-
-        #region DynamicParameters
-        public object GetDynamicParameters()
-        {
-            PSRepositoryInfo repository = RepositorySettings.Read(new[] { Repository }, out string[] _).FirstOrDefault();
-            if (repository is not null && repository.ApiVersion == PSRepositoryInfo.APIVersion.ContainerRegistry)
-            {
-                _pkgPrefix = new ContainerRegistryDynamicParameters();
-                return _pkgPrefix;
-            }
-
-            return null;
-        }
+        /// <summary>
+        /// Prefix for module name which only applies to repositories of type 'ContainerRegistry'
+        /// </summary>
+        [Parameter]
+        [ValidateNotNullOrEmpty]
+        public string ModulePrefix { get; set; }
 
         #endregion
 
@@ -151,16 +142,42 @@ protected override void BeginProcessing()
 
             _networkCredential = Credential != null ? new NetworkCredential(Credential.UserName, Credential.Password) : null;
 
+            // Create a respository story (the PSResourceRepository.xml file) if it does not already exist
+            // This is to create a better experience for those who have just installed v3 and want to get up and running quickly
+            RepositorySettings.CheckRepositoryStore();
+
+            if (MyInvocation.BoundParameters.ContainsKey(nameof(ModulePrefix)))
+            {
+                if (MyInvocation.BoundParameters.ContainsKey(nameof(Repository))) // can remove if Repository is 'Mandatory' parameter
+                {
+                    // at this point it is ensured PSResourceRepository.xml file is created
+                    PSRepositoryInfo repository = RepositorySettings.Read(new[] { Repository }, out string[] _).FirstOrDefault();
+                    if (repository is null || repository.ApiVersion != PSRepositoryInfo.APIVersion.ContainerRegistry)
+                    {
+                        ThrowTerminatingError(new ErrorRecord(
+                            new PSInvalidOperationException("ModulePrefix parameter can only be provided with the Repository parameter for a registered repository of type 'ContainerRegistry'"),
+                            "ModulePrefixParameterIncorrectlyProvided",
+                            ErrorCategory.InvalidOperation,
+                            this));
+                    }
+                }
+                else
+                {
+                    // can remove if Repository is 'Mandatory' parameter
+                    ThrowTerminatingError(new ErrorRecord(
+                        new PSInvalidOperationException("ModulePrefix parameter can only be provided with the Repository parameter."),
+                        "ModulePrefixParameterProvidedWithoutRepositoryParameter",
+                        ErrorCategory.InvalidOperation,
+                        this));
+                }
+            }
+
             if (!string.IsNullOrEmpty(NupkgPath))
             {
                 _isNupkgPathSpecified = true;
                 Path = NupkgPath;
             }
 
-            // Create a respository story (the PSResourceRepository.xml file) if it does not already exist
-            // This is to create a better experience for those who have just installed v3 and want to get up and running quickly
-            RepositorySettings.CheckRepositoryStore();
-
             _publishHelper = new PublishHelper(
                 this,
                 Credential,
@@ -186,18 +203,10 @@ protected override void EndProcessing()
                 return;
             }
 
-            string modulePrefix = _pkgPrefix?.ModulePrefix;
-
-            _publishHelper.PushResource(Repository, modulePrefix, SkipDependenciesCheck, _networkCredential);
+            _publishHelper.PushResource(Repository, ModulePrefix, SkipDependenciesCheck, _networkCredential);
         }
 
         #endregion
 
     }
-
-    public class ContainerRegistryDynamicParameters
-    {
-        [Parameter]
-        public string ModulePrefix { get; set; }
-    }
 }