Prevent users from setting ApiVersion to 'Unknown' in Set-PSResourceRepository and Register-PSResourceRepository (#1892)

Author: Copilot

src/code/RegisterPSResourceRepository.cs

@@ -91,6 +91,7 @@ class RegisterPSResourceRepository : PSCmdlet, IDynamicParameters
         /// Specifies the Api version of the repository to be set.
         /// </summary>
         [Parameter(ParameterSetName = NameParameterSet)]
+        [ValidateSet("V2", "V3", "Local", "NugetServer", "ContainerRegistry")]
         public PSRepositoryInfo.APIVersion ApiVersion { get; set; }
 
         /// <summary>

src/code/SetPSResourceRepository.cs

@@ -88,6 +88,7 @@ public SwitchParameter Trusted
         /// Specifies the Api version of the repository to be set.
         /// </summary>
         [Parameter(ParameterSetName = NameParameterSet)]
+        [ValidateSet("V2", "V3", "Local", "NugetServer", "ContainerRegistry")]
         public PSRepositoryInfo.APIVersion ApiVersion { get; set; }
 
         /// <summary>

test/ResourceRepositoryTests/RegisterPSResourceRepository.Tests.ps1

@@ -404,6 +404,14 @@ Describe "Test Register-PSResourceRepository" -tags 'CI' {
         $res.ApiVersion | Should -Be 'v2'
     }
 
+    It "should throw error when trying to register repository with ApiVersion unknown" {
+        {Register-PSResourceRepository -Name $TestRepoName1 -Uri $tmpDir1Path -ApiVersion "unknown" -ErrorAction Stop} | Should -Throw -ErrorId "ParameterArgumentValidationError,Microsoft.PowerShell.PSResourceGet.Cmdlets.RegisterPSResourceRepository"
+        
+        # Verify the repository was not created
+        $repo = Get-PSResourceRepository $TestRepoName1 -ErrorAction SilentlyContinue
+        $repo | Should -BeNullOrEmpty
+    }
+
     It "should register container registry repository with correct ApiVersion" {
         $ContainerRegistryName = "ACRRepo"
         $ContainerRegistryUri = "https://psresourcegettest.azurecr.io/"

test/ResourceRepositoryTests/SetPSResourceRepository.Tests.ps1

@@ -345,15 +345,16 @@ Describe "Test Set-PSResourceRepository" -tags 'CI' {
         $repo.Priority | Should -Be 25
     }
 
-    It "should not change ApiVersion of repository if -ApiVersion parameter was not used" {
+    It "should throw error when trying to set ApiVersion to unknown" {
         Register-PSResourceRepository -Name $TestRepoName1 -Uri $tmpDir1Path
         $repo = Get-PSResourceRepository $TestRepoName1
         $repoApiVersion = $repo.ApiVersion
         $repoApiVersion | Should -Be "local"
 
-        Set-PSResourceRepository -Name $TestRepoName1 -ApiVersion "unknown" -ErrorVariable err -ErrorAction SilentlyContinue
+        {Set-PSResourceRepository -Name $TestRepoName1 -ApiVersion "unknown" -ErrorAction Stop} | Should -Throw -ErrorId "ParameterArgumentValidationError,Microsoft.PowerShell.PSResourceGet.Cmdlets.SetPSResourceRepository"
+        
+        # Verify the repository ApiVersion was not changed
         $repo = Get-PSResourceRepository $TestRepoName1
-        $repo.ApiVersion | Should -Be "unknown"
-        $err.Count | Should -Be 0
+        $repo.ApiVersion | Should -Be "local"
     }
 }