Add dynamic parameters to Register-PSResourceRepository and Set-PSResourceRepository

Author: alerickson

src/code/RegisterPSResourceRepository.cs

@@ -5,6 +5,7 @@
 using System;
 using System.Collections;
 using System.Collections.Generic;
+using System.Linq;
 using System.Management.Automation;
 
 using Dbg = System.Diagnostics.Debug;
@@ -23,7 +24,7 @@ namespace Microsoft.PowerShell.PSResourceGet.Cmdlets
         SupportsShouldProcess = true,
         ConfirmImpact = ConfirmImpact.Low)]
     public sealed
-    class RegisterPSResourceRepository : PSCmdlet
+    class RegisterPSResourceRepository : PSCmdlet, IDynamicParameters
     {
         #region Members
 
@@ -35,6 +36,7 @@ class RegisterPSResourceRepository : PSCmdlet
         private const string PSGalleryParameterSet = "PSGalleryParameterSet";
         private const string RepositoriesParameterSet = "RepositoriesParameterSet";
         private Uri _uri;
+        private CredentialProviderDynamicParameters _credentialProvider;
 
         #endregion
 
@@ -97,12 +99,6 @@ class RegisterPSResourceRepository : PSCmdlet
         [Parameter(ParameterSetName = NameParameterSet)]
         public PSCredentialInfo CredentialInfo { get; set; }
 
-        /// <summary>
-        /// Specifies which credential provider to use.
-        /// </summary>
-        [Parameter(ParameterSetName = NameParameterSet)]
-        public PSRepositoryInfo.CredentialProviderType CredentialProvider { get; set; }
-
         /// <summary>
         /// When specified, displays the succcessfully registered repository and its information.
         /// </summary>
@@ -117,6 +113,21 @@ class RegisterPSResourceRepository : PSCmdlet
 
         #endregion
 
+        #region DynamicParameters
+
+        public object GetDynamicParameters()
+        {
+            if (Uri.Contains("pkgs.dev.azure.com") || Uri.Contains("pkgs.visualstudio.com"))
+            {
+                _credentialProvider = new CredentialProviderDynamicParameters();
+                return _credentialProvider;
+            }
+
+            return null;
+        }
+
+        #endregion
+
         #region Methods
 
         protected override void BeginProcessing()
@@ -133,12 +144,7 @@ protected override void ProcessRecord()
                 repoApiVersion = ApiVersion;
             }
 
-            PSRepositoryInfo.CredentialProviderType? repoCredentialProvider = null;
-            if (MyInvocation.BoundParameters.ContainsKey(nameof(CredentialProvider)))
-            {
-                repoCredentialProvider = CredentialProvider;
-            }
-
+            PSRepositoryInfo.CredentialProviderType credentialProvider = _credentialProvider.CredentialProvider;
 
             switch (ParameterSetName)
             {
@@ -153,7 +159,7 @@ protected override void ProcessRecord()
 
                     try
                     {
-                        items.Add(RepositorySettings.AddRepository(Name, _uri, Priority, Trusted, repoApiVersion, CredentialInfo, repoCredentialProvider, Force, this, out string errorMsg));
+                        items.Add(RepositorySettings.AddRepository(Name, _uri, Priority, Trusted, repoApiVersion, CredentialInfo, credentialProvider, Force, this, out string errorMsg));
 
                         if (!string.IsNullOrEmpty(errorMsg))
                         {
@@ -367,7 +373,7 @@ private PSRepositoryInfo RepoValidationHelper(Hashtable repo)
             }
 
             if (repo.ContainsKey("CredentialProvider") && 
-                (repo["CredentialProvider"] == null || String.IsNullOrEmpty(repo["CredentialProvider"].ToString()) ||
+                (String.IsNullOrEmpty(repo["CredentialProvider"].ToString()) ||
                 !(repo["CredentialProvider"].ToString().Equals("None", StringComparison.OrdinalIgnoreCase) || 
                 repo["CredentialProvider"].ToString().Equals("AzArtifacts", StringComparison.OrdinalIgnoreCase))))
             {
@@ -429,4 +435,13 @@ private PSRepositoryInfo RepoValidationHelper(Hashtable repo)
 
         #endregion
     }
+
+    public class CredentialProviderDynamicParameters
+    {
+        /// <summary>
+        /// Specifies which credential provider to use.
+        /// </summary>
+        [Parameter]
+        public PSRepositoryInfo.CredentialProviderType CredentialProvider { get; set; }
+    }
 }

src/code/SetPSResourceRepository.cs

@@ -5,6 +5,7 @@
 using System;
 using System.Collections;
 using System.Collections.Generic;
+using System.Linq;
 using System.Management.Automation;
 
 using Dbg = System.Diagnostics.Debug;
@@ -18,14 +19,15 @@ namespace Microsoft.PowerShell.PSResourceGet.Cmdlets
         "PSResourceRepository",
         DefaultParameterSetName = NameParameterSet,
         SupportsShouldProcess = true)]
-    public sealed class SetPSResourceRepository : PSCmdlet
+    public sealed class SetPSResourceRepository : PSCmdlet, IDynamicParameters
     {
         #region Members
 
         private const string NameParameterSet = "NameParameterSet";
         private const string RepositoriesParameterSet = "RepositoriesParameterSet";
         private const int DefaultPriority = -1;
         private Uri _uri;
+        private CredentialProviderDynamicParameters _credentialProvider;
 
         #endregion
 
@@ -92,13 +94,7 @@ public SwitchParameter Trusted
         /// Specifies vault and secret names as PSCredentialInfo for the repository.
         /// </summary>
         [Parameter(ParameterSetName = NameParameterSet)]
-        public PSCredentialInfo CredentialInfo { get; set; }
-
-        /// <summary>
-        /// Specifies which credential provider to use.
-        /// </summary>
-        [Parameter(ParameterSetName = NameParameterSet)]
-        public PSRepositoryInfo.CredentialProviderType CredentialProvider { get; set; }      
+        public PSCredentialInfo CredentialInfo { get; set; } 
 
         /// <summary>
         /// When specified, displays the successfully registered repository and its information.
@@ -108,6 +104,23 @@ public SwitchParameter Trusted
 
         #endregion
 
+        #region DynamicParameters
+
+        public object GetDynamicParameters()
+        {
+            PSRepositoryInfo repository = RepositorySettings.Read(new[] { Name }, out string[] _).FirstOrDefault();
+            if (repository is not null &&
+                  (repository.Uri.AbsoluteUri.Contains("pkgs.dev.azure.com") || repository.Uri.AbsoluteUri.Contains("pkgs.visualstudio.com")))
+            {
+                _credentialProvider = new CredentialProviderDynamicParameters();
+                return _credentialProvider;
+            }
+
+            return null;
+        }
+
+        #endregion
+
         #region Private methods
 
         protected override void BeginProcessing()
@@ -148,6 +161,8 @@ protected override void ProcessRecord()
                 repoApiVersion = ApiVersion;
             }
 
+            PSRepositoryInfo.CredentialProviderType credentialProvider = _credentialProvider.CredentialProvider;
+
             List<PSRepositoryInfo> items = new List<PSRepositoryInfo>();
 
             switch(ParameterSetName)
@@ -163,7 +178,7 @@ protected override void ProcessRecord()
                             DefaultPriority,
                             repoApiVersion,
                             CredentialInfo,
-                            CredentialProvider,
+                            credentialProvider,
                             this,
                             out string errorMsg));
 
@@ -291,6 +306,8 @@ private PSRepositoryInfo RepoValidationHelper(Hashtable repo)
                 return null;
             }
 
+            PSRepositoryInfo.CredentialProviderType credentialProvider = _credentialProvider.CredentialProvider;
+
             try
             {
                 var updatedRepo = RepositorySettings.UpdateRepositoryStore(repo["Name"].ToString(),
@@ -301,7 +318,7 @@ private PSRepositoryInfo RepoValidationHelper(Hashtable repo)
                     DefaultPriority,
                     ApiVersion,
                     repoCredentialInfo,
-                    CredentialProvider,
+                    credentialProvider,
                     this,
                     out string errorMsg);