delete outputDir when it has been created

anamnavi · anamnavi · commit 7a4f691c3d1d · 2025-01-08T12:42:42.000-05:00
diff --git a/src/code/PublishHelper.cs b/src/code/PublishHelper.cs
@@ -455,7 +455,7 @@ internal void PushResource(string Repository, string modulePrefix, bool SkipDepe
                         GetPackageInfoFromNupkg(nupkgFilePath: copiedNupkgFilePath, errRecord: out ErrorRecord pkgInfoErrRecord);
                         if (pkgInfoErrRecord != null)
                         {
-                            _cmdletPassedIn.WriteError(copyErrRecord);
+                            _cmdletPassedIn.WriteError(pkgInfoErrRecord);
                             return;
                         }
                     }
@@ -492,7 +492,8 @@ internal void PushResource(string Repository, string modulePrefix, bool SkipDepe
             }
             finally
             {
-                if (!_isNupkgPathSpecified)
+                // For scenarios such as Publish-PSResource -NupkgPath -Repository <non-container registry repository>, the outputNupkgDir will be set to NupkgPath path, and a temp outputDir folder will not have been created and thus doesn't need to attempt to be deleted
+                if (Directory.Exists(outputDir))
                 {
                     _cmdletPassedIn.WriteVerbose(string.Format("Deleting temporary directory '{0}'", outputDir));
                     Utils.DeleteDirectory(outputDir);

Original file line number	Diff line number	Diff line change
`@@ -455,7 +455,7 @@ internal void PushResource(string Repository, string modulePrefix, bool SkipDepe`
`455`	`455`	`GetPackageInfoFromNupkg(nupkgFilePath: copiedNupkgFilePath, errRecord: out ErrorRecord pkgInfoErrRecord);`
`456`	`456`	`if (pkgInfoErrRecord != null)`
`457`	`457`	`{`
`458`		`- _cmdletPassedIn.WriteError(copyErrRecord);`
	`458`	`+ _cmdletPassedIn.WriteError(pkgInfoErrRecord);`
`459`	`459`	`return;`
`460`	`460`	`}`
`461`	`461`	`}`
`@@ -492,7 +492,8 @@ internal void PushResource(string Repository, string modulePrefix, bool SkipDepe`
`492`	`492`	`}`
`493`	`493`	`finally`
`494`	`494`	`{`
`495`		`- if (!_isNupkgPathSpecified)`
	`495`	`+ // For scenarios such as Publish-PSResource -NupkgPath -Repository <non-container registry repository>, the outputNupkgDir will be set to NupkgPath path, and a temp outputDir folder will not have been created and thus doesn't need to attempt to be deleted`
	`496`	`+ if (Directory.Exists(outputDir))`
`496`	`497`	`{`
`497`	`498`	`_cmdletPassedIn.WriteVerbose(string.Format("Deleting temporary directory '{0}'", outputDir));`
`498`	`499`	`Utils.DeleteDirectory(outputDir);`