Add ValidateSet attribute to ApiVersion parameter and remove redundant validation code

Co-authored-by: alerickson <[email protected]>

Author: Copilot

src/code/RegisterPSResourceRepository.cs

@@ -91,6 +91,7 @@ class RegisterPSResourceRepository : PSCmdlet, IDynamicParameters
         /// Specifies the Api version of the repository to be set.
         /// </summary>
         [Parameter(ParameterSetName = NameParameterSet)]
+        [ValidateSet("V2", "V3", "Local", "NugetServer", "ContainerRegistry")]
         public PSRepositoryInfo.APIVersion ApiVersion { get; set; }
 
         /// <summary>

src/code/SetPSResourceRepository.cs

@@ -88,6 +88,7 @@ public SwitchParameter Trusted
         /// Specifies the Api version of the repository to be set.
         /// </summary>
         [Parameter(ParameterSetName = NameParameterSet)]
+        [ValidateSet("V2", "V3", "Local", "NugetServer", "ContainerRegistry")]
         public PSRepositoryInfo.APIVersion ApiVersion { get; set; }
 
         /// <summary>
@@ -162,14 +163,6 @@ protected override void ProcessRecord()
             PSRepositoryInfo.APIVersion? repoApiVersion = null;
             if (MyInvocation.BoundParameters.ContainsKey(nameof(ApiVersion)))
             {
-                if (ApiVersion == PSRepositoryInfo.APIVersion.Unknown)
-                {
-                    ThrowTerminatingError(new ErrorRecord(
-                        new ArgumentException("ApiVersion 'Unknown' is not a valid value for Set-PSResourceRepository. Valid values are: V2, V3, Local, NugetServer, ContainerRegistry"),
-                        "InvalidApiVersion",
-                        ErrorCategory.InvalidArgument,
-                        this));
-                }
                 repoApiVersion = ApiVersion;
             }
 

test/ResourceRepositoryTests/RegisterPSResourceRepository.Tests.ps1

@@ -405,7 +405,7 @@ Describe "Test Register-PSResourceRepository" -tags 'CI' {
     }
 
     It "should throw error when trying to register repository with ApiVersion unknown" {
-        {Register-PSResourceRepository -Name $TestRepoName1 -Uri $tmpDir1Path -ApiVersion "unknown" -ErrorAction Stop} | Should -Throw -ErrorId "InvalidApiVersion,Microsoft.PowerShell.PSResourceGet.Cmdlets.RegisterPSResourceRepository"
+        {Register-PSResourceRepository -Name $TestRepoName1 -Uri $tmpDir1Path -ApiVersion "unknown" -ErrorAction Stop} | Should -Throw -ErrorId "ParameterArgumentValidationError,Microsoft.PowerShell.PSResourceGet.Cmdlets.RegisterPSResourceRepository"
 
         # Verify the repository was not created
         $repo = Get-PSResourceRepository $TestRepoName1 -ErrorAction SilentlyContinue

test/ResourceRepositoryTests/SetPSResourceRepository.Tests.ps1

@@ -351,7 +351,7 @@ Describe "Test Set-PSResourceRepository" -tags 'CI' {
         $repoApiVersion = $repo.ApiVersion
         $repoApiVersion | Should -Be "local"
 
-        {Set-PSResourceRepository -Name $TestRepoName1 -ApiVersion "unknown" -ErrorAction Stop} | Should -Throw -ErrorId "InvalidApiVersion,Microsoft.PowerShell.PSResourceGet.Cmdlets.SetPSResourceRepository"
+        {Set-PSResourceRepository -Name $TestRepoName1 -ApiVersion "unknown" -ErrorAction Stop} | Should -Throw -ErrorId "ParameterArgumentValidationError,Microsoft.PowerShell.PSResourceGet.Cmdlets.SetPSResourceRepository"
 
         # Verify the repository ApiVersion was not changed
         $repo = Get-PSResourceRepository $TestRepoName1