Provide more intuitive error message when JFrog feed is inactive (#1427)

anamnavi · web-flow · commit c554e2476b14 · 2023-10-04T17:41:49.000-04:00
diff --git a/src/code/V3ServerAPICalls.cs b/src/code/V3ServerAPICalls.cs
@@ -1494,6 +1494,15 @@ private JsonElement[] GetJsonElementArr(string request, string propertyName, out
                     entries = responseEntries.ToArray();
                 }
             }
+            catch (JsonException e)
+            {
+                // scenario where the feed is not active anymore, i.e confirmed for JFrogArtifactory. The default error message is not intuitive.
+                errRecord = new ErrorRecord(
+                    exception: new Exception($"JSON response from repository {Repository.Name} could not be parsed, likely due to the feed being inactive or invalid, with inner exception: {e.Message}"), 
+                    "FindVersionGlobbingFailure",
+                    ErrorCategory.InvalidResult, 
+                    this);
+            }
             catch (Exception e)
             {
                 errRecord = new ErrorRecord(

Original file line number	Diff line number	Diff line change
`@@ -1494,6 +1494,15 @@ private JsonElement[] GetJsonElementArr(string request, string propertyName, out`
`1494`	`1494`	`entries = responseEntries.ToArray();`
`1495`	`1495`	`}`
`1496`	`1496`	`}`
	`1497`	`+ catch (JsonException e)`
	`1498`	`+ {`
	`1499`	`+ // scenario where the feed is not active anymore, i.e confirmed for JFrogArtifactory. The default error message is not intuitive.`
	`1500`	`+ errRecord = new ErrorRecord(`
	`1501`	`+ exception: new Exception($"JSON response from repository {Repository.Name} could not be parsed, likely due to the feed being inactive or invalid, with inner exception: {e.Message}"),`
	`1502`	`+ "FindVersionGlobbingFailure",`
	`1503`	`+ ErrorCategory.InvalidResult,`
	`1504`	`+ this);`
	`1505`	`+ }`
`1497`	`1506`	`catch (Exception e)`
`1498`	`1507`	`{`
`1499`	`1508`	`errRecord = new ErrorRecord(`