Show allowed by policy on PSResourceRepositoryInfo

Author: adityapatwardhan

src/PSGet.Format.ps1xml

@@ -94,6 +94,7 @@
                     <TableColumnHeader><Label>Uri</Label></TableColumnHeader>
                     <TableColumnHeader><Label>Trusted</Label></TableColumnHeader>
                     <TableColumnHeader><Label>Priority</Label></TableColumnHeader>
+                    <TableColumnHeader><Label>IsAllowedByPolicy</Label></TableColumnHeader>
                 </TableHeaders>
                 <TableRowEntries>
                     <TableRowEntry>
@@ -102,6 +103,7 @@
                             <TableColumnItem><PropertyName>Uri</PropertyName></TableColumnItem>
                             <TableColumnItem><PropertyName>Trusted</PropertyName></TableColumnItem>
                             <TableColumnItem><PropertyName>Priority</PropertyName></TableColumnItem>
+                            <TableColumnItem><PropertyName>IsAllowedByPolicy</PropertyName></TableColumnItem>
                         </TableColumnItems>
                     </TableRowEntry>
                 </TableRowEntries>

src/code/GroupPolicyRepositoryEnforcement.cs

@@ -37,7 +37,7 @@ public static bool IsGroupPolicyEnabled()
 
             var values = ReadGPFromRegistry();
 
-            if (values is not null)
+            if (values is not null && values.Count > 0)
             {
                 return true;
             }
@@ -79,7 +79,7 @@ public static bool IsGroupPolicyEnabled()
             }
         }
 
-        internal static bool IsRepositoryAllowed(string repositoryUri)
+        internal static bool IsRepositoryAllowed(Uri repositoryUri)
         {
             bool isAllowed = false;
 
@@ -89,7 +89,7 @@ internal static bool IsRepositoryAllowed(string repositoryUri)
 
                 if (allowedList != null && allowedList.Length > 0)
                 {
-                    isAllowed = allowedList.Any(uri => uri.Equals(new Uri(repositoryUri)));
+                    isAllowed = allowedList.Any(uri => uri.Equals(repositoryUri));
                 }
             }
             else

src/code/PSRepositoryInfo.cs

@@ -27,14 +27,15 @@ public enum APIVersion
 
         #region Constructor
 
-        public PSRepositoryInfo(string name, Uri uri, int priority, bool trusted, PSCredentialInfo credentialInfo, APIVersion apiVersion)
+        public PSRepositoryInfo(string name, Uri uri, int priority, bool trusted, PSCredentialInfo credentialInfo, APIVersion apiVersion, bool allowed)
         {
             Name = name;
             Uri = uri;
             Priority = priority;
             Trusted = trusted;
             CredentialInfo = credentialInfo;
             ApiVersion = apiVersion;
+            IsAllowedByPolicy = allowed;
         }
 
         #endregion
@@ -88,6 +89,11 @@ public enum RepositoryProviderType
         /// </summary>
         public APIVersion ApiVersion { get; }
 
+        // <summary>
+        /// is it allowed by policy
+        /// </summary>
+        public bool IsAllowedByPolicy { get; set; }
+
         #endregion
     }
 }

src/code/RepositorySettings.cs

@@ -9,6 +9,7 @@
 using System.Management.Automation;
 using System.Xml;
 using System.Xml.Linq;
+using Microsoft.PowerShell.PSResourceGet.Cmdlets;
 using static Microsoft.PowerShell.PSResourceGet.UtilClasses.PSRepositoryInfo;
 
 namespace Microsoft.PowerShell.PSResourceGet.UtilClasses
@@ -279,7 +280,9 @@ public static PSRepositoryInfo Add(string repoName, Uri repoUri, int repoPriorit
                 throw new PSInvalidOperationException(String.Format("Adding to repository store failed: {0}", e.Message));
             }
 
-            return new PSRepositoryInfo(repoName, repoUri, repoPriority, repoTrusted, repoCredentialInfo, apiVersion);
+            bool isAllowed = GroupPolicyRepositoryEnforcement.IsGroupPolicyEnabled() ? GroupPolicyRepositoryEnforcement.IsRepositoryAllowed(repoUri) : true;
+
+            return new PSRepositoryInfo(repoName, repoUri, repoPriority, repoTrusted, repoCredentialInfo, apiVersion, isAllowed);
         }
 
         /// <summary>
@@ -436,13 +439,22 @@ public static PSRepositoryInfo Update(string repoName, Uri repoUri, int repoPrio
                         node.Attribute(PSCredentialInfo.SecretNameAttribute).Value);
                 }
 
+                if (GroupPolicyRepositoryEnforcement.IsGroupPolicyEnabled())
+                {
+                    var allowedList = GroupPolicyRepositoryEnforcement.GetAllowedRepositoryURIs();
+
+                }
+
+                bool isAllowed = GroupPolicyRepositoryEnforcement.IsGroupPolicyEnabled() ? GroupPolicyRepositoryEnforcement.IsRepositoryAllowed(thisUrl) : true;
+
                 RepositoryProviderType repositoryProvider= GetRepositoryProviderType(thisUrl);
                 updatedRepo = new PSRepositoryInfo(repoName,
                     thisUrl,
                     Int32.Parse(node.Attribute("Priority").Value),
                     Boolean.Parse(node.Attribute("Trusted").Value),
                     thisCredentialInfo,
-                    resolvedAPIVersion);
+                    resolvedAPIVersion,
+                    isAllowed);
 
                 // Close the file
                 root.Save(FullRepositoryPath);
@@ -522,14 +534,18 @@ public static List<PSRepositoryInfo> Remove(string[] repoNames, out string[] err
 
                 string attributeUrlUriName = urlAttributeExists ? "Url" : "Uri";
                 Uri repoUri = new Uri(node.Attribute(attributeUrlUriName).Value);
+
+                bool isAllowed = GroupPolicyRepositoryEnforcement.IsGroupPolicyEnabled() ? GroupPolicyRepositoryEnforcement.IsRepositoryAllowed(repoUri) : true;
+
                 RepositoryProviderType repositoryProvider= GetRepositoryProviderType(repoUri);
                 removedRepos.Add(
                     new PSRepositoryInfo(repo,
                         new Uri(node.Attribute(attributeUrlUriName).Value),
                         Int32.Parse(node.Attribute("Priority").Value),
                         Boolean.Parse(node.Attribute("Trusted").Value),
                         repoCredentialInfo,
-                        (PSRepositoryInfo.APIVersion)Enum.Parse(typeof(PSRepositoryInfo.APIVersion), node.Attribute("APIVersion").Value, ignoreCase: true)));
+                        (PSRepositoryInfo.APIVersion)Enum.Parse(typeof(PSRepositoryInfo.APIVersion), node.Attribute("APIVersion").Value, ignoreCase: true),
+                        isAllowed));
 
                 // Remove item from file
                 node.Remove();
@@ -654,12 +670,16 @@ public static List<PSRepositoryInfo> Read(string[] repoNames, out string[] error
                     }
 
                     RepositoryProviderType repositoryProvider= GetRepositoryProviderType(thisUrl);
+
+                    bool isAllowed = GroupPolicyRepositoryEnforcement.IsGroupPolicyEnabled() ? GroupPolicyRepositoryEnforcement.IsRepositoryAllowed(thisUrl) : true;
+
                     PSRepositoryInfo currentRepoItem = new PSRepositoryInfo(repo.Attribute("Name").Value,
                         thisUrl,
                         Int32.Parse(repo.Attribute("Priority").Value),
                         Boolean.Parse(repo.Attribute("Trusted").Value),
                         thisCredentialInfo,
-                        (PSRepositoryInfo.APIVersion)Enum.Parse(typeof(PSRepositoryInfo.APIVersion), repo.Attribute("APIVersion").Value, ignoreCase: true));
+                        (PSRepositoryInfo.APIVersion)Enum.Parse(typeof(PSRepositoryInfo.APIVersion), repo.Attribute("APIVersion").Value, ignoreCase: true),
+                        isAllowed);
 
                     foundRepos.Add(currentRepoItem);
                 }
@@ -758,12 +778,16 @@ public static List<PSRepositoryInfo> Read(string[] repoNames, out string[] error
                         }
 
                         RepositoryProviderType repositoryProvider= GetRepositoryProviderType(thisUrl);
+
+                        bool isAllowed = GroupPolicyRepositoryEnforcement.IsGroupPolicyEnabled() ? GroupPolicyRepositoryEnforcement.IsRepositoryAllowed(thisUrl) : true;
+
                         PSRepositoryInfo currentRepoItem = new PSRepositoryInfo(node.Attribute("Name").Value,
                             thisUrl,
                             Int32.Parse(node.Attribute("Priority").Value),
                             Boolean.Parse(node.Attribute("Trusted").Value),
                             thisCredentialInfo,
-                            (PSRepositoryInfo.APIVersion)Enum.Parse(typeof(PSRepositoryInfo.APIVersion), node.Attribute("APIVersion").Value, ignoreCase: true));
+                            (PSRepositoryInfo.APIVersion)Enum.Parse(typeof(PSRepositoryInfo.APIVersion), node.Attribute("APIVersion").Value, ignoreCase: true),
+                            isAllowed);
 
                         foundRepos.Add(currentRepoItem);
                     }