Add -ApiVersion to Register-PSResourceRepository (#1431)

Author: alerickson

src/code/RegisterPSResourceRepository.cs

@@ -85,6 +85,12 @@ class RegisterPSResourceRepository : PSCmdlet
         [ValidateRange(0, 100)]
         public int Priority { get; set; } = DefaultPriority;
 
+        /// <summary>
+        /// Specifies the Api version of the repository to be set.
+        /// </sumamry>
+        [Parameter(ParameterSetName = NameParameterSet)]
+        public PSRepositoryInfo.APIVersion ApiVersion { get; set; }
+
         /// <summary>
         /// Specifies vault and secret names as PSCredentialInfo for the repository.
         /// </summary>
@@ -115,6 +121,12 @@ protected override void ProcessRecord()
         {
             List<PSRepositoryInfo> items = new List<PSRepositoryInfo>();
 
+            PSRepositoryInfo.APIVersion? repoApiVersion = null;
+            if (MyInvocation.BoundParameters.ContainsKey(nameof(ApiVersion)))
+            {
+                repoApiVersion = ApiVersion;
+            }
+
             switch (ParameterSetName)
             {
                 case NameParameterSet:
@@ -128,7 +140,7 @@ protected override void ProcessRecord()
 
                     try
                     {
-                        items.Add(RepositorySettings.AddRepository(Name, _uri, Priority, Trusted, null, CredentialInfo, Force, this, out string errorMsg));
+                        items.Add(RepositorySettings.AddRepository(Name, _uri, Priority, Trusted, repoApiVersion, CredentialInfo, Force, this, out string errorMsg));
 
                         if (!string.IsNullOrEmpty(errorMsg))
                         {
@@ -325,14 +337,28 @@ private PSRepositoryInfo RepoValidationHelper(Hashtable repo)
                 return null;
             }
 
+            if (repo.ContainsKey("ApiVersion") && 
+                (repo["ApiVersion"] == null || String.IsNullOrEmpty(repo["ApiVersion"].ToString()) ||
+                !(repo["ApiVersion"].ToString().Equals("local") || repo["ApiVersion"].ToString().Equals("v2") || 
+                repo["ApiVersion"].ToString().Equals("v3") || repo["ApiVersion"].ToString().Equals("nugetServer") || repo["ApiVersion"].ToString().Equals("unknown"))))
+            {
+                WriteError(new ErrorRecord(
+                    new PSInvalidOperationException("Repository ApiVersion must be either 'local', 'v2', 'v3', 'nugetServer' or 'unknown'"),
+                    "IncorrectApiVersionForRepositoriesParameterSetRegistration",
+                    ErrorCategory.InvalidArgument,
+                    this));
+
+                return null;
+            }
+
             try
             {
                 WriteDebug($"Registering repository '{repo["Name"]}' with uri '{repoUri}'");
                 var addedRepo = RepositorySettings.AddRepository(repo["Name"].ToString(),
                     repoUri,
                     repo.ContainsKey("Priority") ? Convert.ToInt32(repo["Priority"].ToString()) : DefaultPriority,
                     repo.ContainsKey("Trusted") ? Convert.ToBoolean(repo["Trusted"].ToString()) : DefaultTrusted,
-                    apiVersion: null,
+                    apiVersion: repo.ContainsKey("Trusted") ? (PSRepositoryInfo.APIVersion?) repo["ApiVersion"] : null,
                     repoCredentialInfo,
                     Force,
                     this,

test/ResourceRepositoryTests/RegisterPSResourceRepository.Tests.ps1

@@ -394,4 +394,13 @@ Describe "Test Register-PSResourceRepository" -tags 'CI' {
         $res.Uri.LocalPath | Should -Be "\"
         $res.ApiVersion | Should -Be "local"
     }
+
+    It "should register repository with explicitly provided ApiVersion" {
+        Register-PSResourceRepository -Name $TestRepoName1 -Uri $tmpDir1Path -ApiVersion 'v2'
+        $res = Get-PSResourceRepository -Name $TestRepoName1
+
+        $res.Name | Should -Be $TestRepoName1
+        $res.Uri.LocalPath | Should -Contain $tmpDir1Path
+        $res.ApiVersion | Should -Be 'v2'
+    }
 }