Skip to content

Conversation

adityapatwardhan
Copy link
Member

@adityapatwardhan adityapatwardhan commented Feb 19, 2025

PR Summary

This pull request includes several changes to improve the handling and testing of unauthenticated access tokens for container registries. The most important changes include updating token templates, modifying access token retrieval logic, and adding new tests for unauthenticated repositories.

Improvements to token handling:

Modifications to access token retrieval logic:

Code simplification:

Testing improvements:

PR Context

Unauthenticated ACR other than MCR respond with an auth challenge to acquire an anonymous token. This token is required for further operations.

PR Checklist

Fix NRE when getting scope

Fix call to realm

Fix scope

Add content to the webrequest

Remove extra debug

Fix error message
@adityapatwardhan
Copy link
Member Author

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@adityapatwardhan
Copy link
Member Author

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@adityapatwardhan
Copy link
Member Author

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@adityapatwardhan
Copy link
Member Author

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@adityapatwardhan
Copy link
Member Author

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@adityapatwardhan
Copy link
Member Author

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@adityapatwardhan
Copy link
Member Author

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@anamnavi anamnavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adityapatwardhan adityapatwardhan merged commit 9c741e4 into master Feb 21, 2025
12 checks passed
@adityapatwardhan adityapatwardhan deleted the MCRAuthChallenge branch February 21, 2025 18:27
alerickson pushed a commit to alerickson/PSResourceGet that referenced this pull request Jun 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants