Rules>PSAlignAssignmentStatement: Treat single kvp hashtables as being on a single line, and not checked for violations. (#1986)

Co-authored-by: Christoph Bergmeister <[email protected]>

Author: liamjpeters

Rules/AlignAssignmentStatement.cs

@@ -314,6 +314,11 @@ private static List<Tuple<IScriptExtent, IScriptExtent>> GetExtents(
 
         private bool HasPropertiesOnSeparateLines(IEnumerable<Tuple<IScriptExtent, IScriptExtent>> tuples)
         {
+            if (tuples.Count() == 1)
+            {
+                // If the hashtable has just a single key-value pair, it does not have properties on separate lines
+                return false;
+            }
             var lines = new HashSet<int>();
             foreach (var kvp in tuples)
             {

Tests/Rules/AlignAssignmentStatement.tests.ps1

@@ -75,6 +75,33 @@ $x = @{ }
             Invoke-ScriptAnalyzer -ScriptDefinition $def -Settings $settings | Get-Count | Should -Be 0
 
         }
+
+        It "Should ignore if a hashtable has a single key-value pair on a single line" {
+            $def = @'
+$x = @{ 'key'="value" }
+'@
+            Invoke-ScriptAnalyzer -ScriptDefinition $def -Settings $settings | Get-Count | Should -Be 0
+
+        }
+
+        It "Should ignore if a hashtable has a single key-value pair across multiple lines" {
+            $def = @'
+$x = @{ 
+    'key'="value" 
+}
+'@
+            Invoke-ScriptAnalyzer -ScriptDefinition $def -Settings $settings | Get-Count | Should -Be 0
+
+        }
+
+        It "Should ignore if a hashtable has multiple key-value pairs on a single line" {
+            $def = @'
+$x = @{ 'key'="value"; 'key2'="value2"; 'key3WithLongerName'="value3" }
+'@
+            Invoke-ScriptAnalyzer -ScriptDefinition $def -Settings $settings | Get-Count | Should -Be 0
+
+        }
+
     }
 
     Context "When assignment statements are in DSC Configuration" {