Fix discrepancy in loading custom rules

Loading an external rule module with version errors out on PSv4. But it works on PSv5. So we remove the sample rule with version from the glob pattern by renaming it.

Author: Kapil Borle

Engine/ScriptAnalyzer.cs

@@ -1,4 +1,5 @@
-//
+
+//
 // Copyright (c) Microsoft Corporation.
 //
 // THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR

Tests/Engine/CustomizedRule.tests.ps1

@@ -108,7 +108,7 @@ Describe "Test importing correct customized rules" {
 
 		It "will show the custom rules when given glob with recurse switch" {
 			$customizedRulePath = Get-ScriptAnalyzerRule  -RecurseCustomRulePath -CustomizedRulePath $directory\samplerule* | Where-Object {$_.RuleName -eq $measure}
-			$customizedRulePath.Count | Should be 4
+			$customizedRulePath.Count | Should be 3
 		}		
     }
 
@@ -147,7 +147,7 @@ Describe "Test importing correct customized rules" {
 
 		    It "will show the custom rules when given glob with recurse switch" {
 			    $customizedRulePath = Invoke-ScriptAnalyzer  $directory\TestScript.ps1 -RecurseCustomRulePath -CustomizedRulePath $directory\samplerule* | Where-Object {$_.Message -eq $message}
-			    $customizedRulePath.Count | Should be 4
+			    $customizedRulePath.Count | Should be 3
 		    }
 
             It "Using IncludeDefaultRules Switch with CustomRulePath" {
@@ -164,23 +164,26 @@ Describe "Test importing correct customized rules" {
                 $customizedRulePath = Invoke-ScriptAnalyzer $directory\TestScript.ps1
                 $customizedRulePath.Count | Should Be 1
             }
+	
+		if ($PSVersionTable.PSVersion -ge [Version]'5.0')
+		{
+			It "loads custom rules that contain version in their path" {
+			$customizedRulePath = Invoke-ScriptAnalyzer $directory\TestScript.ps1 -CustomRulePath $directory\VersionedSampleRule\SampleRuleWithVersion
+			$customizedRulePath.Count | Should Be 1
 
-	    It "loads custom rules that contain version in their path" {
-	       $customizedRulePath = Invoke-ScriptAnalyzer $directory\TestScript.ps1 -CustomRulePath $directory\SampleRuleWithVersion\SampleRuleWithVersion
-	       $customizedRulePath.Count | Should Be 1
-
-	       $customizedRulePath = Get-ScriptAnalyzerRule -CustomRulePath $directory\SampleRuleWithVersion\SampleRuleWithVersion
-	       $customizedRulePath.Count | Should Be 1
-	    }
+			$customizedRulePath = Get-ScriptAnalyzerRule -CustomRulePath $directory\VersionedSampleRulen\SampleRuleWithVersion
+			$customizedRulePath.Count | Should Be 1
+			}
 
-	    It "loads custom rules that contain version in their path with the RecurseCustomRule switch" {
-	       $customizedRulePath = Invoke-ScriptAnalyzer $directory\TestScript.ps1 -CustomRulePath $directory\SampleRuleWithVersion -RecurseCustomRulePath
-	       $customizedRulePath.Count | Should Be 1
+			It "loads custom rules that contain version in their path with the RecurseCustomRule switch" {
+			$customizedRulePath = Invoke-ScriptAnalyzer $directory\TestScript.ps1 -CustomRulePath $directory\VersionedSampleRulen -RecurseCustomRulePath
+			$customizedRulePath.Count | Should Be 1
 
-	       $customizedRulePath = Get-ScriptAnalyzerRule -CustomRulePath $directory\SampleRuleWithVersion -RecurseCustomRulePath
-	       $customizedRulePath.Count | Should Be 1
+			$customizedRulePath = Get-ScriptAnalyzerRule -CustomRulePath $directory\VersionedSampleRulen -RecurseCustomRulePath
+			$customizedRulePath.Count | Should Be 1
 
-	    }
+			}
+		}
         }
 
     }