Check if reference platform is valid

Author: Kapil Borle

Rules/UseCompatibleCmdlets.cs

@@ -42,8 +42,8 @@ public class UseCompatibleCmdlets : AstVisitor, IScriptRule
         private string scriptPath;
         private bool IsInitialized;
         private bool hasInitializationError;
-        private string referenceFile;
-        private readonly string defaultReferenceFile = "desktop-5.1.14393.206-windows.json";
+        private string referencePlatform;
+        private readonly string defaultReferencePlatform = "desktop-5.1.14393.206-windows";
 
         public UseCompatibleCmdlets()
         {
@@ -278,15 +278,21 @@ private void SetupCmdletsDictionary()
             object referenceObject;
             if (ruleArgs.TryGetValue("reference", out referenceObject))
             {
-                referenceFile = referenceObject as string;
-                if (referenceFile == null)
+                referencePlatform = referenceObject as string;
+                if (referencePlatform == null)
                 {
                     return;
                 }
             }
             else
             {
-                referenceFile = defaultReferenceFile;
+                referencePlatform = defaultReferencePlatform;
+            }
+
+            // check if the reference file has valid platformSpec
+            if (!IsValidPlatformString(referencePlatform))
+            {
+                return;
             }
 
             object modeObject;
@@ -336,7 +342,7 @@ private void SetupCmdletsDictionary()
         /// </summary>
         private bool ContainsReferenceFile(string directory)
         {
-            return File.Exists(Path.Combine(directory, referenceFile));
+            return File.Exists(Path.Combine(directory, referencePlatform + ".json"));
         }
 
         /// <summary>
@@ -379,6 +385,16 @@ private string GetShippedSettingsDirectory()
             return settingsPath;
         }
 
+        private bool IsValidPlatformString(string fileNameWithoutExt)
+        {
+            string psedition, psversion, os;
+            return GetVersionInfoFromPlatformString(
+                fileNameWithoutExt,
+                out psedition,
+                out psversion,
+                out os);
+        }
+
         /// <summary>
         /// Gets PowerShell Edition, Version and OS from input string
         /// </summary>