AvoidReservedWordsAsFunctionNames: factor our function name for readability

Co-authored-by: Patrick Meinecke <[email protected]>

Author: liamjpeters

Rules/AvoidReservedWordsAsFunctionNames.cs

@@ -65,15 +65,14 @@ public IEnumerable<DiagnosticRecord> AnalyzeScript(Ast ast, string fileName)
 
             foreach (var function in functionDefinitions)
             {
-                if (reservedWords.Contains(
-                    Helper.Instance.FunctionNameWithoutScope(function.Name)
-                ))
+                string functionName = Helper.Instance.FunctionNameWithoutScope(function.Name);
+                if (reservedWords.Contains(functionName))
                 {
                     yield return new DiagnosticRecord(
                         string.Format(
                             CultureInfo.CurrentCulture,
                             Strings.AvoidReservedWordsAsFunctionNamesError,
-                            Helper.Instance.FunctionNameWithoutScope(function.Name)),
+                            functionName),
                         Helper.Instance.GetScriptExtentForFunctionName(function) ?? function.Extent,
                         GetName(),
                         DiagnosticSeverity.Warning,