Add module manifest check in AvoidUsingDeprecatedManifestFields

Kapil Borle · Kapil Borle · commit 8c597d03c656 · 2016-08-02T18:33:53.000-07:00
diff --git a/Rules/AvoidUsingDeprecatedManifestFields.cs b/Rules/AvoidUsingDeprecatedManifestFields.cs
@@ -39,8 +39,11 @@ public IEnumerable<DiagnosticRecord> AnalyzeScript(Ast ast, string fileName)
             {
                 throw new ArgumentNullException(Strings.NullAstErrorMessage);
             }
-
-            if (String.Equals(System.IO.Path.GetExtension(fileName), ".psd1", StringComparison.OrdinalIgnoreCase))
+            if (fileName == null)
+            {
+                yield break;
+            }
+            if (Helper.IsModuleManifest(fileName))
             {
                 var ps = System.Management.Automation.PowerShell.Create();
                 IEnumerable<PSObject> result = null;

Original file line number	Diff line number	Diff line change
`@@ -39,8 +39,11 @@ public IEnumerable<DiagnosticRecord> AnalyzeScript(Ast ast, string fileName)`
`39`	`39`	`{`
`40`	`40`	`throw new ArgumentNullException(Strings.NullAstErrorMessage);`
`41`	`41`	`}`
`42`		`-`
`43`		`- if (String.Equals(System.IO.Path.GetExtension(fileName), ".psd1", StringComparison.OrdinalIgnoreCase))`
	`42`	`+ if (fileName == null)`
	`43`	`+ {`
	`44`	`+ yield break;`
	`45`	`+ }`
	`46`	`+ if (Helper.IsModuleManifest(fileName))`
`44`	`47`	`{`
`45`	`48`	`var ps = System.Management.Automation.PowerShell.Create();`
`46`	`49`	`IEnumerable<PSObject> result = null;`