Fix rule tests for PSv4

Author: Kapil Borle

Tests/Rules/AvoidUnloadableModuleOrMissingRequiredFieldInManifest.tests.ps1

@@ -9,7 +9,7 @@ $noHashtableFilepath = Join-Path $directory "TestBadModule\NoHashtable.psd1"
 
 Describe "MissingRequiredFieldModuleManifest" {
     BeforeAll {
-        Import-Module (Join-Path $directory "PSScriptAnalyzerTestHelper.psm1")
+        Import-Module (Join-Path $directory "PSScriptAnalyzerTestHelper.psm1") -Force
     }
 
     AfterAll{

Tests/Rules/PSCredentialType.tests.ps1

@@ -1,4 +1,4 @@
-Import-Module PSScriptAnalyzer 
+Import-Module PSScriptAnalyzer
 $violationMessage = "The Credential parameter in 'Credential' must be of type PSCredential. For PowerShell 4.0 and earlier, please define a credential transformation attribute, e.g. [System.Management.Automation.Credential()], after the PSCredential type attribute."
 $violationName = "PSUsePSCredentialType"
 $directory = Split-Path -Parent $MyInvocation.MyCommand.Path
@@ -16,9 +16,14 @@ Describe "PSCredentialType" {
         }
     }
 
-    Context "When there are no violations" {
-        It "returns no violations" {
-            $noViolations.Count | Should Be 0
+    $expectedViolationCount = 0
+    if ($PSVersionTable.PSVersion -lt [Version]'5.0')
+    {
+        $expectedViolationCount = 1
+    }
+    Context ("When there are {0} violations" -f $expectedViolationCount) {
+        It ("returns {0} violations" -f $expectedViolationCount) {
+            $noViolations.Count | Should Be $expectedViolationCount
         }
     }
 }

Tests/Rules/PSScriptAnalyzerTestHelper.psm1

@@ -5,19 +5,20 @@ Function Get-ExtentText
 	[string] $scriptPath
 	)
 	$scriptContent = Get-Content -Path $scriptPath
-	$start = [System.Management.Automation.Language.ScriptPosition]::new($scriptPath, $violation.StartLineNumber, $violation.StartColumnNumber, $scriptContent[$violation.StartLineNumber - 1])
-	$end = [System.Management.Automation.Language.ScriptPosition]::new($scriptPath, $violation.EndLineNumber, $violation.EndColumnNumber, $scriptContent[$violation.EndLineNumber - 1])	
-	$extent = [System.Management.Automation.Language.ScriptExtent]::new($start, $end)
+	$typeScriptPos = 'System.Management.Automation.Language.ScriptPosition'
+	$start = New-Object -TypeName $typeScriptPos -ArgumentList @($scriptPath, $violation.StartLineNumber, $violation.StartColumnNumber, $scriptContent[$violation.StartLineNumber - 1])
+	$end = New-Object -TypeName $typeScriptPos -ArgumentList @($scriptPath, $violation.EndLineNumber, $violation.EndColumnNumber, $scriptContent[$violation.EndLineNumber - 1])
+	$extent = New-Object -TypeName 'System.Management.Automation.Language.ScriptExtent' -ArgumentList @($start, $end)
 	return($extent.Text)
 }
 
 Function Test-CorrectionExtent
 {
 	Param(
 		[string] $violationFilepath,
-		[Microsoft.Windows.PowerShell.ScriptAnalyzer.Generic.DiagnosticRecord] $diagnosticRecord, 
-		[int] $correctionsCount, 
-		[string] $violationText, 
+		[Microsoft.Windows.PowerShell.ScriptAnalyzer.Generic.DiagnosticRecord] $diagnosticRecord,
+		[int] $correctionsCount,
+		[string] $violationText,
 		[string] $correctionText
 	)
 	$corrections = $diagnosticRecord.SuggestedCorrections

appveyor.yml

@@ -56,4 +56,4 @@ on_finish:
         @(
             # You can add other artifacts here
             (ls $zipFile)
-        ) | % { Push-AppveyorArtifact $_.FullName }
+        ) | % { Push-AppveyorArtifact $_.FullName }