Ensure results are ordered by script line numbers

raghushantha · raghushantha · commit a52317852a16 · 2016-01-05T13:21:45.000-08:00
diff --git a/Engine/ScriptAnalyzer.cs b/Engine/ScriptAnalyzer.cs
@@ -1639,7 +1639,8 @@ public IEnumerable<DiagnosticRecord> AnalyzeSyntaxTree(
 
             #endregion
 
-            IEnumerable<DiagnosticRecord> diagnosticsList = diagnostics;
+            // Need to reverse the concurrentbag to ensure that results are sorted in the increasing order of line numbers
+            IEnumerable<DiagnosticRecord> diagnosticsList = diagnostics.Reverse();
 
             if (severity != null)
             {

Original file line number	Diff line number	Diff line change
`@@ -1639,7 +1639,8 @@ public IEnumerable<DiagnosticRecord> AnalyzeSyntaxTree(`
`1639`	`1639`
`1640`	`1640`	`#endregion`
`1641`	`1641`
`1642`		`- IEnumerable<DiagnosticRecord> diagnosticsList = diagnostics;`
	`1642`	`+ // Need to reverse the concurrentbag to ensure that results are sorted in the increasing order of line numbers`
	`1643`	`+ IEnumerable<DiagnosticRecord> diagnosticsList = diagnostics.Reverse();`
`1643`	`1644`
`1644`	`1645`	`if (severity != null)`
`1645`	`1646`	`{`