Suppress External Rules (#585)

* External/Custom rule supression

* Revert to the previous GetExternalRecord() call on all external rules, rather than 1-by-1 to continue to take advantage of the runspacepool stuff.
New SupressRule() function that takes a single DiagnosticRecord and list of suppressions - bounces the RuleName of the record against that list.

Author: charlieschmidt

Engine/ScriptAnalyzer.cs

@@ -1454,6 +1454,23 @@ private Tuple<List<SuppressedRecord>, List<DiagnosticRecord>> SuppressRule(
             }
             return records;
         }
+        private Tuple<List<SuppressedRecord>, List<DiagnosticRecord>> SuppressRule(
+            DiagnosticRecord ruleDiagnosticRecord,
+            Dictionary<string, List<RuleSuppression>> ruleSuppressions
+            )
+        {
+            List<ErrorRecord> suppressRuleErrors;
+            var records = Helper.Instance.SuppressRule(
+                ruleDiagnosticRecord.RuleName,
+                ruleSuppressions,
+                new List<DiagnosticRecord> { ruleDiagnosticRecord },
+                out suppressRuleErrors);
+            foreach (var error in suppressRuleErrors)
+            {
+                this.outputWriter.WriteError(error);
+            }
+            return records;
+        }
 
         /// <summary>
         /// Analyzes the syntax tree of a script file that has already been parsed.
@@ -1752,13 +1769,21 @@ public IEnumerable<DiagnosticRecord> AnalyzeSyntaxTree(
                     }
                 }
 
-                foreach (var record in this.GetExternalRecord(scriptAst, scriptTokens, exRules.ToArray(), fileName))
+                foreach (var ruleRecord in this.GetExternalRecord(scriptAst, scriptTokens, exRules.ToArray(), fileName))
                 {
-                    diagnostics.Add(record);
+                    var records = SuppressRule(ruleRecord, ruleSuppressions);
+                    foreach (var record in records.Item2)
+                    {
+                        diagnostics.Add(record);
+                    }
+                    foreach (var suppressedRec in records.Item1)
+                    {
+                        suppressed.Add(suppressedRec);
+                    }
                 }
             }
-
-#endregion
+            
+            #endregion
 
             // Need to reverse the concurrentbag to ensure that results are sorted in the increasing order of line numbers
             IEnumerable<DiagnosticRecord> diagnosticsList = diagnostics.Reverse();