Added null check for BaseObject

yutingc · yutingc · commit c0e1393d063a · 2015-05-18T16:10:51.000-07:00
diff --git a/Rules/AvoidUsingDeprecatedManifestFields.cs b/Rules/AvoidUsingDeprecatedManifestFields.cs
@@ -63,7 +63,13 @@ public IEnumerable<DiagnosticRecord> AnalyzeScript(Ast ast, string fileName)
                 {
                     foreach (var warning in result)
                     {
-                       yield return new DiagnosticRecord(String.Format(CultureInfo.CurrentCulture, warning.BaseObject.ToString()), ast.Extent, GetName(), DiagnosticSeverity.Warning, fileName);
+                        if (warning.BaseObject != null)
+                        {
+                            yield return
+                                new DiagnosticRecord(
+                                    String.Format(CultureInfo.CurrentCulture, warning.BaseObject.ToString()), ast.Extent,
+                                    GetName(), DiagnosticSeverity.Warning, fileName);
+                        }
                     }
                 }
 

Original file line number	Diff line number	Diff line change
`@@ -63,7 +63,13 @@ public IEnumerable<DiagnosticRecord> AnalyzeScript(Ast ast, string fileName)`
`63`	`63`	`{`
`64`	`64`	`foreach (var warning in result)`
`65`	`65`	`{`
`66`		`- yield return new DiagnosticRecord(String.Format(CultureInfo.CurrentCulture, warning.BaseObject.ToString()), ast.Extent, GetName(), DiagnosticSeverity.Warning, fileName);`
	`66`	`+ if (warning.BaseObject != null)`
	`67`	`+ {`
	`68`	`+ yield return`
	`69`	`+ new DiagnosticRecord(`
	`70`	`+ String.Format(CultureInfo.CurrentCulture, warning.BaseObject.ToString()), ast.Extent,`
	`71`	`+ GetName(), DiagnosticSeverity.Warning, fileName);`
	`72`	`+ }`
`67`	`73`	`}`
`68`	`74`	`}`
`69`	`75`