Localize error messages in PlaceOpenBrace rule

Author: Kapil Borle

Rules/PlaceOpenBrace.cs

@@ -126,7 +126,7 @@ private IEnumerable<DiagnosticRecord> FindViolationsForBraceShouldBeOnSameLine(
                     && tokens[k - 1].Kind == TokenKind.NewLine)
                 {
                     yield return new DiagnosticRecord(
-                        GetError(),
+                        GetError(Strings.PlaceOpenBraceErrorShouldBeOnSameLine),
                         tokens[k].Extent,
                         GetName(),
                         GetDiagnosticSeverity(),
@@ -155,7 +155,7 @@ private IEnumerable<DiagnosticRecord> FindViolationsForNoNewLineAfterBrace(
                     && tokens[k + 1].Kind != TokenKind.NewLine)
                 {
                     yield return new DiagnosticRecord(
-                        GetError(),
+                        GetError(Strings.PlaceOpenBraceErrorNoNewLineAfterBrace),
                         tokens[k].Extent,
                         GetName(),
                         GetDiagnosticSeverity(),
@@ -204,7 +204,7 @@ private IEnumerable<DiagnosticRecord> FindViolationsForBraceShouldNotBeOnSameLin
                     && !tokensToIgnore.Contains(tokens[k]))
                 {
                     yield return new DiagnosticRecord(
-                        GetError(),
+                        GetError(Strings.PlaceOpenBraceErrorShouldNotBeOnSameLine),
                         tokens[k].Extent,
                         GetName(),
                         GetDiagnosticSeverity(),
@@ -284,12 +284,9 @@ public override string GetCommonName()
             return string.Format(CultureInfo.CurrentCulture, Strings.PlaceOpenBraceCommonName);
         }
 
-        public string GetError()
+        public string GetError(string errorString)
         {
-            return string.Format(
-                CultureInfo.CurrentCulture,
-                Strings.PlaceOpenBraceError,
-                "same");
+            return string.Format(CultureInfo.CurrentCulture, errorString);
         }
 
         /// <summary>

Rules/Strings.resx

@@ -1,17 +1,17 @@
 <?xml version="1.0" encoding="utf-8"?>
 <root>
-  <!-- 
-    Microsoft ResX Schema 
-    
+  <!--
+    Microsoft ResX Schema
+
     Version 2.0
-    
-    The primary goals of this format is to allow a simple XML format 
-    that is mostly human readable. The generation and parsing of the 
-    various data types are done through the TypeConverter classes 
+
+    The primary goals of this format is to allow a simple XML format
+    that is mostly human readable. The generation and parsing of the
+    various data types are done through the TypeConverter classes
     associated with the data types.
-    
+
     Example:
-    
+
     ... ado.net/XML headers & schema ...
     <resheader name="resmimetype">text/microsoft-resx</resheader>
     <resheader name="version">2.0</resheader>
@@ -26,36 +26,36 @@
         <value>[base64 mime encoded string representing a byte array form of the .NET Framework object]</value>
         <comment>This is a comment</comment>
     </data>
-                
-    There are any number of "resheader" rows that contain simple 
+
+    There are any number of "resheader" rows that contain simple
     name/value pairs.
-    
-    Each data row contains a name, and value. The row also contains a 
-    type or mimetype. Type corresponds to a .NET class that support 
-    text/value conversion through the TypeConverter architecture. 
-    Classes that don't support this are serialized and stored with the 
+
+    Each data row contains a name, and value. The row also contains a
+    type or mimetype. Type corresponds to a .NET class that support
+    text/value conversion through the TypeConverter architecture.
+    Classes that don't support this are serialized and stored with the
     mimetype set.
-    
-    The mimetype is used for serialized objects, and tells the 
-    ResXResourceReader how to depersist the object. This is currently not 
+
+    The mimetype is used for serialized objects, and tells the
+    ResXResourceReader how to depersist the object. This is currently not
     extensible. For a given mimetype the value must be set accordingly:
-    
-    Note - application/x-microsoft.net.object.binary.base64 is the format 
-    that the ResXResourceWriter will generate, however the reader can 
+
+    Note - application/x-microsoft.net.object.binary.base64 is the format
+    that the ResXResourceWriter will generate, however the reader can
     read any of the formats listed below.
-    
+
     mimetype: application/x-microsoft.net.object.binary.base64
-    value   : The object must be serialized with 
+    value   : The object must be serialized with
             : System.Runtime.Serialization.Formatters.Binary.BinaryFormatter
             : and then encoded with base64 encoding.
-    
+
     mimetype: application/x-microsoft.net.object.soap.base64
-    value   : The object must be serialized with 
+    value   : The object must be serialized with
             : System.Runtime.Serialization.Formatters.Soap.SoapFormatter
             : and then encoded with base64 encoding.
 
     mimetype: application/x-microsoft.net.object.bytearray.base64
-    value   : The object must be serialized into a byte array 
+    value   : The object must be serialized into a byte array
             : using a System.ComponentModel.TypeConverter
             : and then encoded with base64 encoding.
     -->
@@ -879,8 +879,14 @@
   <data name="PlaceOpenBraceDescription" xml:space="preserve">
     <value>Place open braces either on the same line as the preceding expression or on a new line.</value>
   </data>
-  <data name="PlaceOpenBraceError" xml:space="preserve">
-    <value>Open brace not on {0} line</value>
+  <data name="PlaceOpenBraceErrorShouldBeOnSameLine" xml:space="preserve">
+    <value>Open brace not on same line as preceding keyword. It should be on the same line.</value>
+  </data>
+  <data name="PlaceOpenBraceErrorShouldNotBeOnSameLine" xml:space="preserve">
+    <value>Open brace is on same line as preceding keyword. It should be on a new line.</value>
+  </data>
+  <data name="PlaceOpenBraceErrorNoNewLineAfterBrace" xml:space="preserve">
+    <value>No new line after open brace. A new line should follown an open brace.</value>
   </data>
   <data name="PlaceCloseBraceName" xml:space="preserve">
     <value>PlaceCloseBrace</value>