Update UsePSCredentialType tests

Author: Kapil Borle

Tests/PSScriptAnalyzerTestHelper.psm1

@@ -43,6 +43,11 @@ Function Test-PSVersionV3
 	$PSVersionTable.PSVersion.Major -eq 3
 }
 
+Function Test-PSVersionV4
+{
+	$PSVersionTable.PSVersion.Major -eq 4
+}
+
 Function Get-Count
 {
 	Begin {$count = 0}
@@ -55,4 +60,5 @@ Export-ModuleMember -Function Test-CorrectionExtent
 Export-ModuleMember -Function Test-PSEditionCoreCLR
 Export-ModuleMember -Function Test-PSEditionCoreCLRLinux
 Export-ModuleMember -Function Test-PSVersionV3
+Export-ModuleMember -Function Test-PSVersionV4
 Export-ModuleMember -Function Get-Count

Tests/Rules/PSCredentialType.tests.ps1

@@ -1,14 +1,21 @@
-Import-Module PSScriptAnalyzer
+$directory = Split-Path -Parent $MyInvocation.MyCommand.Path
+$testRootDirectory = Split-Path -Parent $directory
+Import-Module (Join-Path $testRootDirectory 'PSScriptAnalyzerTestHelper.psm1')
+Import-Module PSScriptAnalyzer
+
 $violationMessage = "The Credential parameter in 'Credential' must be of type PSCredential. For PowerShell 4.0 and earlier, please define a credential transformation attribute, e.g. [System.Management.Automation.Credential()], after the PSCredential type attribute."
 $violationName = "PSUsePSCredentialType"
-$directory = Split-Path -Parent $MyInvocation.MyCommand.Path
 $violations = Invoke-ScriptAnalyzer $directory\PSCredentialType.ps1 | Where-Object {$_.RuleName -eq $violationName}
 $noViolations = Invoke-ScriptAnalyzer $directory\PSCredentialTypeNoViolations.ps1 | Where-Object {$_.RuleName -eq $violationName}
 
 Describe "PSCredentialType" {
     Context "When there are violations" {
-        It "has 2 PSCredential type violation" {
-            $violations.Count | Should Be 2
+        $expectedViolations = 1
+        if (Test-PSVersionV3 -or Test-PSVersionV4) {
+            $expectedViolations = 2
+        }
+        It ("has {0} PSCredential type violation" -f $expectedViolations) {
+            $violations.Count | Should Be $expectedViolations
         }
 
         It "has the correct description message" {
@@ -31,9 +38,9 @@ function Get-Credential
 
     }
 
-    Context ("When there are {0} violations" -f $expectedViolationCount) {
-        It ("returns {0} violations" -f $expectedViolationCount) {
-            $noViolations.Count | Should Be $expectedViolationCount
+    Context ("When there are no violations") {
+        It "returns no violations" {
+            $noViolations.Count | Should Be 0
         }
     }
 }