Skip to content

Commit 07f3e1b

Browse files
Added ifdef statement
1 parent 2f5f1d2 commit 07f3e1b

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

2-Draft-Accepted/RFCNNN-Performance-Testing.md

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,15 +3,16 @@ RFC:
33
Author: Aditya Patwardhan
44
Status: Draft
55
SupercededBy:
6-
Version: 0.1
6+
Version: 0.2
77
Area: Testing
88
Comments Due: 10/15/2017
99
Plan to implement: Yes
1010
---
1111

1212
# Performance testing for PowerShell
1313

14-
This RFC proposes the plan to add AppInsights instrumentation to collect performance telemetry from daily CI runs. This RFC specifies the additional telemetry that will be added.
14+
This RFC proposes the plan to add AppInsights instrumentation to collect performance telemetry from daily CI runs.
15+
This RFC specifies the additional telemetry that will be added.
1516

1617
## Motivation
1718

@@ -26,6 +27,9 @@ Typically, we would need large number of iterations to get stable numbers.
2627
A [metric aggregator](https://docs.microsoft.com/en-us/azure/application-insights/app-insights-api-custom-events-metrics#trackmetric) will be used to compose the data from iterations and then upload the telemetry data points.
2728
This will avoid throttling and dropping of events.
2829

30+
The metric collection code will be within a `#ifdef` and will only be compiled in when PowerShell is built with `Performance` configuration.
31+
There will be no performance metric collection code in official builds.
32+
2933
### Proposed performance test scenarios
3034

3135
* PowerShell startup time for cold and warm start.

0 commit comments

Comments
 (0)