Skip to content

Commit 521381f

Browse files
author
joeyaiello
committed
add RFC notes for June 24, 2019
1 parent 936519a commit 521381f

File tree

2 files changed

+38
-0
lines changed

2 files changed

+38
-0
lines changed
File renamed without changes.
Lines changed: 38 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,38 @@
1+
# RFC Meeting - June 24, 2019
2+
3+
## Attendees
4+
5+
No quorum today...
6+
7+
* Jim Truher
8+
* Dongbo Wang
9+
* Joey Aiello
10+
11+
## Notes
12+
13+
* PSGet 3.0 RFC has been updated, need to review with Steve when he's back
14+
* Closed PR #138 on the basis that it misunderstood the current process
15+
* Cursorily reviewed and briefly discussed PR 202 for side-by-side `pwsh` support
16+
* Initial reaction is that this is explicitly a non-goal
17+
* We are primarily trying to follow a fix-forward approach to `pwsh`
18+
* Complexity of managing multiple namespaces in package managers is very high
19+
* Also discouraged by distros
20+
* Process on aging PRs out?
21+
* `Waiting on Author` for some period of time?
22+
* Open question: do we give it a number and reject it, or do we just close the PR?
23+
* The former provides more visibility to others who may want to pick it up
24+
* PR after would move it to 2-Draft-Accepted with the existing number
25+
* Probably won't use automation to remove `Waiting on Author`
26+
* Only the author's response would change it
27+
* Still haven't codified the way that experimental features reduce the burden to RFCs
28+
* Jim: "code speaks louder than words"
29+
* Jim did ulimit/umask implementation before he submitted the PR
30+
* At a bare minimum, input/output examples are necessary
31+
* Dongbo: "if you're really going to implement it, you need to think about all the details up front"
32+
* We don't want to think of the implementation plan, but having a design is critical
33+
* One great example is Test-Connection changes (#172)
34+
* Only 121 lines, and it gives everything you need to know about input, output, parameter sets, etc.
35+
* We may need to be more direct about possible breakage that RFCs cause
36+
* Reviewed login shell RFC (PR #186)
37+
* Pending performance measurements of Rob's new method, we will take his method of `pwsh -l` / `pwsh -LoginShell` instead of using `pwsh-login`
38+
* Open question: on a container, does Docker implicitly start the pwsh entrypoint from sh?

0 commit comments

Comments
 (0)