Skip to content

Commit aa6bfc7

Browse files
committed
Fix FindsDetailsForBuiltInCommand test
And delete "find details" for non-commands (as they all get their display strings set on creation now).
1 parent f69694c commit aa6bfc7

File tree

3 files changed

+1
-119
lines changed

3 files changed

+1
-119
lines changed

test/PowerShellEditorServices.Test.Shared/SymbolDetails/FindsDetailsForTypeSymbols.cs

Lines changed: 0 additions & 50 deletions
This file was deleted.

test/PowerShellEditorServices.Test.Shared/SymbolDetails/TypeSymbolDetails.ps1

Lines changed: 0 additions & 23 deletions
This file was deleted.

test/PowerShellEditorServices.Test/Language/SymbolsServiceTests.cs

Lines changed: 1 addition & 46 deletions
Original file line numberDiff line numberDiff line change
@@ -729,52 +729,7 @@ public async Task FindsDetailsForBuiltInCommand()
729729
FindsDetailsForBuiltInCommandData.SourceDetails.StartLineNumber,
730730
FindsDetailsForBuiltInCommandData.SourceDetails.StartColumnNumber).ConfigureAwait(true);
731731

732-
Assert.NotNull(symbolDetails.Documentation);
733-
Assert.NotEqual("", symbolDetails.Documentation);
734-
}
735-
736-
[Fact]
737-
public async Task FindsDetailsWithSignatureForEnumMember()
738-
{
739-
SymbolDetails symbolDetails = await symbolsService.FindSymbolDetailsAtLocationAsync(
740-
GetScriptFile(FindsDetailsForTypeSymbolsData.EnumMemberSourceDetails),
741-
FindsDetailsForTypeSymbolsData.EnumMemberSourceDetails.StartLineNumber,
742-
FindsDetailsForTypeSymbolsData.EnumMemberSourceDetails.StartColumnNumber).ConfigureAwait(true);
743-
744-
Assert.Equal("MyEnum.First", symbolDetails.SymbolReference.DisplayString);
745-
}
746-
747-
[Fact]
748-
public async Task FindsDetailsWithSignatureForProperty()
749-
{
750-
SymbolDetails symbolDetails = await symbolsService.FindSymbolDetailsAtLocationAsync(
751-
GetScriptFile(FindsDetailsForTypeSymbolsData.PropertySourceDetails),
752-
FindsDetailsForTypeSymbolsData.PropertySourceDetails.StartLineNumber,
753-
FindsDetailsForTypeSymbolsData.PropertySourceDetails.StartColumnNumber).ConfigureAwait(true);
754-
755-
Assert.Equal("string SuperClass.SomePropWithDefault", symbolDetails.SymbolReference.DisplayString);
756-
}
757-
758-
[Fact]
759-
public async Task FindsDetailsWithSignatureForConstructor()
760-
{
761-
SymbolDetails symbolDetails = await symbolsService.FindSymbolDetailsAtLocationAsync(
762-
GetScriptFile(FindsDetailsForTypeSymbolsData.ConstructorSourceDetails),
763-
FindsDetailsForTypeSymbolsData.ConstructorSourceDetails.StartLineNumber,
764-
FindsDetailsForTypeSymbolsData.ConstructorSourceDetails.StartColumnNumber).ConfigureAwait(true);
765-
766-
Assert.Equal("SuperClass.SuperClass([string]$name)", symbolDetails.SymbolReference.DisplayString);
767-
}
768-
769-
[Fact]
770-
public async Task FindsDetailsWithSignatureForMethod()
771-
{
772-
SymbolDetails symbolDetails = await symbolsService.FindSymbolDetailsAtLocationAsync(
773-
GetScriptFile(FindsDetailsForTypeSymbolsData.MethodSourceDetails),
774-
FindsDetailsForTypeSymbolsData.MethodSourceDetails.StartLineNumber,
775-
FindsDetailsForTypeSymbolsData.MethodSourceDetails.StartColumnNumber).ConfigureAwait(true);
776-
777-
Assert.Equal("string SuperClass.MyClassMethod([string]$param1, $param2, [int]$param3)", symbolDetails.SymbolReference.DisplayString);
732+
Assert.Equal("Gets the processes that are running on the local computer.", symbolDetails.Documentation);
778733
}
779734

780735
[Fact]

0 commit comments

Comments
 (0)