Skip to content

Commit b9e0020

Browse files
committed
Serialize "request_seq" as int in debug adapter
Previously we had been serializing "request_seq" as a string in our reponses to VS Code's debug adapter client. Very recently their code changed such that our responses were no longer being handled correctly. This is due to a change on their side which assumes that "request_seq" will always be returned as an int. This change corrects that in our debug adapter message serialization.
1 parent 86dd212 commit b9e0020

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

src/PowerShellEditorServices.Protocol/MessageProtocol/Serializers/V8MessageSerializer.cs

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,11 @@ public JObject SerializeMessage(Message message)
3434
}
3535
else if (message.MessageType == MessageType.Response)
3636
{
37+
int messageId = 0;
38+
int.TryParse(message.Id, out messageId);
39+
3740
messageObject.Add("type", JToken.FromObject("response"));
38-
messageObject.Add("request_seq", JToken.FromObject(message.Id));
41+
messageObject.Add("request_seq", JToken.FromObject(messageId));
3942
messageObject.Add("command", message.Method);
4043

4144
if (message.Error != null)

0 commit comments

Comments
 (0)