Use NameRegion for definition, workplace jump and hover

Author: andyleejordan

src/PowerShellEditorServices/Services/Symbols/ParameterSetSignatures.cs

@@ -46,8 +46,8 @@ public ParameterSetSignatures(IEnumerable<CommandParameterSetInfo> commandInfoSe
                 paramSetSignatures.Add(new ParameterSetSignature(setInfo));
             }
             Signatures = paramSetSignatures.ToArray();
-            CommandName = foundSymbol.ScriptRegion.Text;
-            ScriptRegion = foundSymbol.ScriptRegion;
+            CommandName = foundSymbol.NameRegion.Text;
+            ScriptRegion = foundSymbol.NameRegion;
         }
     }
 

src/PowerShellEditorServices/Services/TextDocument/Handlers/DefinitionHandler.cs

@@ -54,7 +54,7 @@ public override async Task<LocationOrLocationLinks> Handle(DefinitionParams requ
                             new Location
                             {
                                 Uri = DocumentUri.From(foundDefinition.FilePath),
-                                Range = foundDefinition.ScriptRegion.ToRange()
+                                Range = foundDefinition.NameRegion.ToRange()
                             }));
                 }
             }

src/PowerShellEditorServices/Services/TextDocument/Handlers/DocumentSymbolHandler.cs

@@ -74,8 +74,9 @@ public override async Task<SymbolInformationOrDocumentSymbolContainer> Handle(Do
                     continue;
                 }
 
-                // TODO: This should be a DocumentSymbol now as SymbolInformation is deprecated.
-                // But this requires figuring out how to populate `children`.
+                // TODO: This should be a DocumentSymbol now as SymbolInformation is deprecated. But
+                // this requires figuring out how to populate `children`. Once we do that, the range
+                // can be NameRegion.
                 //
                 // symbols.Add(new SymbolInformationOrDocumentSymbol(new DocumentSymbol
                 // {

src/PowerShellEditorServices/Services/TextDocument/Handlers/HoverHandler.cs

@@ -70,7 +70,7 @@ await _symbolsService.FindSymbolDetailsAtLocationAsync(
             return new Hover
             {
                 Contents = new MarkedStringsOrMarkupContent(symbolInfo),
-                Range = symbolDetails.SymbolReference.ScriptRegion.ToRange()
+                Range = symbolDetails.SymbolReference.NameRegion.ToRange()
             };
         }
     }

src/PowerShellEditorServices/Services/TextDocument/Handlers/ReferencesHandler.cs

@@ -54,7 +54,7 @@ public override async Task<LocationContainer> Handle(ReferenceParams request, Ca
                 locations.Add(new Location
                 {
                     Uri = DocumentUri.From(foundReference.FilePath),
-                    Range = foundReference.ScriptRegion.ToRange()
+                    Range = foundReference.NameRegion.ToRange()
                 });
             }
 

src/PowerShellEditorServices/Services/Workspace/Handlers/WorkspaceSymbolsHandler.cs

@@ -76,7 +76,7 @@ public override async Task<Container<SymbolInformation>> Handle(WorkspaceSymbolP
                     Location location = new()
                     {
                         Uri = DocumentUri.From(foundOccurrence.FilePath),
-                        Range = foundOccurrence.ScriptRegion.ToRange()
+                        Range = foundOccurrence.NameRegion.ToRange()
                     };
 
                     // TODO: This should be a WorkplaceSymbol now as SymbolInformation is deprecated.