Skip to content

Commit d75ebc1

Browse files
author
Kapil Borle
committed
Use line and column instead of position in request
Using FilePosition file type causes JSON serializer to crash. Hence we use line and column numbers.
1 parent 66f14f3 commit d75ebc1

File tree

1 file changed

+12
-7
lines changed

1 file changed

+12
-7
lines changed

src/PowerShellEditorServices.Protocol/LanguageServer/FormattingScriptRegionRequest.cs

Lines changed: 12 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -12,17 +12,17 @@ namespace Microsoft.PowerShell.EditorServices.Protocol.LanguageServer
1212
/// <summary>
1313
/// Class to encapsulate the request type.
1414
/// </summary>
15-
class FormattingScriptRegionRequest
15+
class ScriptRegionRequest
1616
{
1717
public static readonly
18-
RequestType<FormattingScriptRegionRequestParams, FormattingScriptRegionRequestResult> Type =
19-
RequestType<FormattingScriptRegionRequestParams, FormattingScriptRegionRequestResult>.Create("powerShell/getFormattingScriptRegion");
18+
RequestType<ScriptRegionRequestParams, ScriptRegionRequestResult> Type =
19+
RequestType<ScriptRegionRequestParams, ScriptRegionRequestResult>.Create("powerShell/getScriptRegion");
2020
}
2121

2222
/// <summary>
2323
/// Class to encapsulate the request parameters.
2424
/// </summary>
25-
class FormattingScriptRegionRequestParams
25+
class ScriptRegionRequestParams
2626
{
2727
/// <summary>
2828
/// Path of the file for which the markers are requested.
@@ -35,15 +35,20 @@ class FormattingScriptRegionRequestParams
3535
public string character;
3636

3737
/// <summary>
38-
/// Character position
38+
/// 1-based line number of the character
3939
/// </summary>
40-
public FilePosition filePosition;
40+
public int line;
41+
42+
/// <summary>
43+
/// 1-based column number of the character
44+
/// </summary>
45+
public int column;
4146
}
4247

4348
/// <summary>
4449
/// Class to encapsulate the result of marker request.
4550
/// </summary>
46-
class FormattingScriptRegionRequestResult
51+
class ScriptRegionRequestResult
4752
{
4853
/// <summary>
4954
/// A region in the script that encapsulates the given character/position which is suitable for

0 commit comments

Comments
 (0)