Ignore intentional sync aways in Dispose methods

Author: andyleejordan

src/PowerShellEditorServices/Server/PsesServiceCollectionExtensions.cs

@@ -48,8 +48,9 @@ public static IServiceCollection AddPsesLanguageServices(
                         // is ready, it will be available. NOTE: We cannot await this because it
                         // uses a lazy initialization to avoid a race with the dependency injection
                         // framework, see the EditorObject class for that!
+#pragma warning disable VSTHRD110
                         extensionService.InitializeAsync();
-
+#pragma warning restore VSTHRD110
                         return extensionService;
                     })
                 .AddSingleton<AnalysisService>();

src/PowerShellEditorServices/Services/DebugAdapter/Handlers/LaunchAndAttachHandler.cs

@@ -453,7 +453,7 @@ await _executionService.ExecutePSCommandAsync(
         // PSES sends the initialized event at the end of the Launch/Attach handler
 
         // The way that the Omnisharp server works is that this OnStarted handler runs after OnInitialized
-        // (after the Initialize DAP response is sent to the client) but before the _Initalized_ DAP event
+        // (after the Initialize DAP response is sent to the client) but before the _Initialized_ DAP event
         // gets sent to the client. Because of the way PSES handles breakpoints,
         // we can't send the Initialized event until _after_ we finish the Launch/Attach handler.
         // The flow above depicts this. To achieve this, we wait until _debugStateService.ServerStarted

src/PowerShellEditorServices/Services/PowerShell/Context/PowerShellContextFrame.cs

@@ -79,7 +79,7 @@ protected virtual void Dispose(bool disposing)
         public void Dispose()
         {
             // Do not change this code. Put cleanup code in 'Dispose(bool disposing)' method
-            Dispose(disposing: true);
+            Dispose(true);
             GC.SuppressFinalize(this);
         }
 

src/PowerShellEditorServices/Services/PowerShell/Context/PowerShellVersionDetails.cs

@@ -1,11 +1,11 @@
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT License.
 
-using Microsoft.Extensions.Logging;
-using Microsoft.PowerShell.EditorServices.Services.PowerShell.Utility;
 using System;
 using System.Collections;
 using System.Linq;
+using Microsoft.Extensions.Logging;
+using Microsoft.PowerShell.EditorServices.Services.PowerShell.Utility;
 
 namespace Microsoft.PowerShell.EditorServices.Services.PowerShell.Context
 {
@@ -91,7 +91,7 @@ public PowerShellVersionDetails(
         /// Gets the PowerShell version details for the given runspace.
         /// </summary>
         /// <param name="logger">An ILogger implementation used for writing log messages.</param>
-        /// <param name="pwsh">The PowerShell instance for which to to get the version.</param>
+        /// <param name="pwsh">The PowerShell instance for which to get the version.</param>
         /// <returns>A new PowerShellVersionDetails instance.</returns>
         public static PowerShellVersionDetails GetVersionDetails(ILogger logger, PowerShell pwsh)
         {

test/PowerShellEditorServices.Test.E2E/Processes/ServerProcess.cs

@@ -43,7 +43,7 @@ protected ServerProcess(ILoggerFactory loggerFactory)
         }
 
         /// <summary>
-        ///     Finaliser for <see cref="ServerProcess"/>.
+        ///     Finalizer for <see cref="ServerProcess"/>.
         /// </summary>
         ~ServerProcess()
         {
@@ -53,7 +53,11 @@ protected ServerProcess(ILoggerFactory loggerFactory)
         /// <summary>
         ///     Dispose of resources being used by the launcher.
         /// </summary>
-        public void Dispose() => Dispose(true);
+        public void Dispose()
+        {
+            Dispose(true);
+            GC.SuppressFinalize(this);
+        }
 
         /// <summary>
         ///     Dispose of resources being used by the launcher.

test/PowerShellEditorServices.Test/Debugging/DebugServiceTests.cs

@@ -63,7 +63,9 @@ public void Dispose()
         {
             debugService.Abort();
             debuggerStoppedQueue.Dispose();
+#pragma warning disable VSTHRD002
             psesHost.StopAsync().Wait();
+#pragma warning restore VSTHRD002
             GC.SuppressFinalize(this);
         }
 

test/PowerShellEditorServices.Test/Extensions/ExtensionCommandTests.cs

@@ -39,7 +39,9 @@ public ExtensionCommandTests()
 
         public void Dispose()
         {
+#pragma warning disable VSTHRD002
             psesHost.StopAsync().Wait();
+#pragma warning restore VSTHRD002
             GC.SuppressFinalize(this);
         }
 

test/PowerShellEditorServices.Test/Language/CompletionHandlerTests.cs

@@ -35,7 +35,9 @@ public CompletionHandlerTests()
 
         public void Dispose()
         {
+#pragma warning disable VSTHRD002
             psesHost.StopAsync().Wait();
+#pragma warning restore VSTHRD002
             GC.SuppressFinalize(this);
         }
 

test/PowerShellEditorServices.Test/Language/SymbolsServiceTests.cs

@@ -46,7 +46,9 @@ public SymbolsServiceTests()
 
         public void Dispose()
         {
+#pragma warning disable VSTHRD002
             psesHost.StopAsync().GetAwaiter().GetResult();
+#pragma warning restore VSTHRD002
             CommandHelpers.s_cmdletToAliasCache.Clear();
             CommandHelpers.s_aliasToCmdletCache.Clear();
             GC.SuppressFinalize(this);

test/PowerShellEditorServices.Test/Session/PsesInternalHostTests.cs

@@ -27,7 +27,9 @@ public class PsesInternalHostTests : IDisposable
 
         public void Dispose()
         {
+#pragma warning disable VSTHRD002
             psesHost.StopAsync().Wait();
+#pragma warning restore VSTHRD002
             GC.SuppressFinalize(this);
         }