Clean out some dead code

Author: JustinGrote

src/PowerShellEditorServices/Services/TextDocument/RenameService.cs

@@ -132,13 +132,6 @@ internal static TextEdit[] RenameVariable(Ast symbol, Ast scriptAst, RenameParam
             throw new HandlerErrorException($"Asked to rename a variable but the target is not a viable variable type: {symbol.GetType()}. This is a bug, file an issue if you see this.");
         }
 
-        // RenameVariableVisitor visitor = new(
-        //     requestParams.NewName,
-        //     symbol.Extent.StartLineNumber,
-        //     symbol.Extent.StartColumnNumber,
-        //     scriptAst,
-        //     createParameterAlias
-        // );
         NewRenameVariableVisitor visitor = new(
             symbol, requestParams.NewName
         );

src/PowerShellEditorServices/Utility/AstExtensions.cs

@@ -196,42 +196,6 @@ public static string GetUnqualifiedName(this VariableExpressionAst ast)
             ? ast.VariablePath.ToString()
             : ast.VariablePath.ToString().Split(':').Last();
 
-    /// <summary>
-    /// Finds the closest variable definition to the given reference.
-    /// </summary>
-    public static VariableExpressionAst? FindVariableDefinition(this Ast ast, Ast reference)
-    {
-        string? name = reference switch
-        {
-            VariableExpressionAst var => var.GetUnqualifiedName(),
-            CommandParameterAst param => param.ParameterName,
-            // StringConstantExpressionAst stringConstant => ,
-            _ => null
-        };
-        if (name is null) { return null; }
-
-        return ast.FindAll(candidate =>
-        {
-            if (candidate is not VariableExpressionAst candidateVar) { return false; }
-            if (candidateVar.GetUnqualifiedName() != name) { return false; }
-            if
-            (
-                // TODO: Replace with a position match
-                candidateVar.Extent.EndLineNumber > reference.Extent.StartLineNumber
-                ||
-                (
-                    candidateVar.Extent.EndLineNumber == reference.Extent.StartLineNumber
-                    && candidateVar.Extent.EndColumnNumber >= reference.Extent.StartColumnNumber
-                )
-            )
-            {
-                return false;
-            }
-
-            return candidateVar.HasParent(reference.Parent);
-        }, true).Cast<VariableExpressionAst>().LastOrDefault();
-    }
-
     public static Ast GetHighestParent(this Ast ast)
         => ast.Parent is null ? ast : ast.Parent.GetHighestParent();
 
@@ -405,7 +369,6 @@ public static bool TryGetFunction(this ParameterAst ast, out FunctionDefinitionA
         return false;
     }
 
-
     /// <summary>
     /// Finds the highest variable expression within a variable assignment within the current scope of the provided variable reference. Returns the original object if it is the highest assignment or null if no assignment was found. It is assumed the reference is part of a larger Ast.
     /// </summary>
@@ -546,62 +509,6 @@ public static bool TryGetFunction(this ParameterAst ast, out FunctionDefinitionA
         return null;
     }
 
-    public static bool WithinScope(this Ast Target, Ast Child)
-    {
-        Ast childParent = Child.Parent;
-        Ast? TargetScope = Target.GetScopeBoundary();
-        while (childParent != null)
-        {
-            if (childParent is FunctionDefinitionAst FuncDefAst)
-            {
-                if (Child is VariableExpressionAst VarExpAst && !IsVariableExpressionAssignedInTargetScope(VarExpAst, FuncDefAst))
-                {
-
-                }
-                else
-                {
-                    break;
-                }
-            }
-            if (childParent == TargetScope)
-            {
-                break;
-            }
-            childParent = childParent.Parent;
-        }
-        return childParent == TargetScope;
-    }
-
-    public static bool IsVariableExpressionAssignedInTargetScope(this VariableExpressionAst node, Ast scope)
-    {
-        bool r = false;
-
-        List<VariableExpressionAst> VariableAssignments = node.FindAll(ast =>
-        {
-            return ast is VariableExpressionAst VarDef &&
-            VarDef.Parent is AssignmentStatementAst or ParameterAst &&
-            VarDef.VariablePath.UserPath.ToLower() == node.VariablePath.UserPath.ToLower() &&
-            // Look Backwards from the node above
-            (VarDef.Extent.EndLineNumber < node.Extent.StartLineNumber ||
-            (VarDef.Extent.EndColumnNumber <= node.Extent.StartColumnNumber &&
-            VarDef.Extent.EndLineNumber <= node.Extent.StartLineNumber)) &&
-            // Must be within the the designated scope
-            VarDef.Extent.StartLineNumber >= scope.Extent.StartLineNumber;
-        }, true).Cast<VariableExpressionAst>().ToList();
-
-        if (VariableAssignments.Count > 0)
-        {
-            r = true;
-        }
-        // Node is probably the first Assignment Statement within scope
-        if (node.Parent is AssignmentStatementAst && node.Extent.StartLineNumber >= scope.Extent.StartLineNumber)
-        {
-            r = true;
-        }
-
-        return r;
-    }
-
     public static bool HasParent(this Ast ast, Ast parent)
     {
         Ast? current = ast;