- Make LoadAssemblyInPsesLoadContext an Instance method instead of static. Fixes crash on windows arm64.

tsmarvin · tsmarvin · commit f36fcd5f7ff1 · 2025-06-29T04:26:02.000-07:00
diff --git a/src/PowerShellEditorServices/Extensions/Api/EditorExtensionServiceProvider.cs b/src/PowerShellEditorServices/Extensions/Api/EditorExtensionServiceProvider.cs
@@ -162,7 +162,9 @@ public static object GetPsesAssemblyLoadContext()
         /// </summary>
         /// <param name="assemblyPath">The absolute path of the assembly to load.</param>
         /// <returns>The loaded assembly object.</returns>
-        public static Assembly LoadAssemblyInPsesLoadContext(string assemblyPath)
+#pragma warning disable CA1822 // Mark members as static
+        public Assembly LoadAssemblyInPsesLoadContext(string assemblyPath)
+#pragma warning restore CA1822 // Mark members as static
         {
             if (!VersionUtils.IsNetCore)
             {

Original file line number	Diff line number	Diff line change
`@@ -162,7 +162,9 @@ public static object GetPsesAssemblyLoadContext()`
`162`	`162`	`/// </summary>`
`163`	`163`	`/// <param name="assemblyPath">The absolute path of the assembly to load.</param>`
`164`	`164`	`/// <returns>The loaded assembly object.</returns>`
`165`		`- public static Assembly LoadAssemblyInPsesLoadContext(string assemblyPath)`
	`165`	`+#pragma warning disable CA1822 // Mark members as static`
	`166`	`+ public Assembly LoadAssemblyInPsesLoadContext(string assemblyPath)`
	`167`	`+#pragma warning restore CA1822 // Mark members as static`
`166`	`168`	`{`
`167`	`169`	`if (!VersionUtils.IsNetCore)`
`168`	`170`	`{`