Fix #264: Variable and parameter IntelliSense broken in VS Code 1.4.0

daviwil · daviwil · commit fc9a0e87e943 · 2016-08-09T12:57:21.000-07:00
In VS Code 1.4.0, the completion behavior has changed to require the use
of the filterText field to ensure that completions which insert text not
equal to the label field will get displayed. Since PowerShell often
suggests completions with labels different than the actual insert string,
this caused some completions to be broken.

The fix is to put the value of the insertText field into the filterText
field also.
diff --git a/src/PowerShellEditorServices.Protocol/Server/LanguageServer.cs b/src/PowerShellEditorServices.Protocol/Server/LanguageServer.cs
@@ -1164,6 +1164,7 @@ private static CompletionItem CreateCompletionItem(
                 Detail = detailString,
                 Documentation = documentationString,
                 SortText = sortText,
+                FilterText = completionDetails.CompletionText,
                 TextEdit = new TextEdit
                 {
                     NewText = completionDetails.CompletionText,

Original file line number	Diff line number	Diff line change
`@@ -1164,6 +1164,7 @@ private static CompletionItem CreateCompletionItem(`
`1164`	`1164`	`Detail = detailString,`
`1165`	`1165`	`Documentation = documentationString,`
`1166`	`1166`	`SortText = sortText,`
	`1167`	`+ FilterText = completionDetails.CompletionText,`
`1167`	`1168`	`TextEdit = new TextEdit`
`1168`	`1169`	`{`
`1169`	`1170`	`NewText = completionDetails.CompletionText,`