SkipChildren doesn't work for nested function situations. More tests fixed

Author: JustinGrote

src/PowerShellEditorServices/Services/TextDocument/RenameService.cs

@@ -240,12 +240,8 @@ public AstVisitAction Visit(Ast ast)
         if (ShouldRename(ast))
         {
             Edits.Add(GetRenameFunctionEdit(ast));
-            return AstVisitAction.Continue;
-        }
-        else
-        {
-            return AstVisitAction.SkipChildren;
         }
+        return AstVisitAction.Continue;
 
         // TODO: Is there a way we can know we are fully outside where the function might be referenced, and if so, call a AstVisitAction Abort as a perf optimization?
     }

test/PowerShellEditorServices.Test.Shared/Refactoring/Functions/FunctionInnerIsNestedRenamed.ps1

@@ -1,8 +1,8 @@
 function outer {
-    function bar {
-        Write-Host "Inside nested foo"
+    function Renamed {
+        Write-Host 'Inside nested foo'
     }
-    bar
+    Renamed
 }
 
 function foo {

test/PowerShellEditorServices.Test.Shared/Refactoring/Functions/FunctionWithInnerFunction.ps1

@@ -1,6 +1,6 @@
 function OuterFunction {
     function NewInnerFunction {
-        Write-Host "This is the inner function"
+        Write-Host 'This is the inner function'
     }
     NewInnerFunction
 }

test/PowerShellEditorServices.Test.Shared/Refactoring/Functions/FunctionWithInnerFunctionRenamed.ps1

@@ -1,7 +1,7 @@
 function OuterFunction {
-    function RenamedInnerFunction {
-        Write-Host "This is the inner function"
+    function Renamed {
+        Write-Host 'This is the inner function'
     }
-    RenamedInnerFunction
+    Renamed
 }
 OuterFunction

test/PowerShellEditorServices.Test.Shared/Refactoring/Functions/RefactorFunctionTestCases.cs

@@ -14,15 +14,15 @@ public class RefactorFunctionTestCases
         new("FunctionCmdlet.ps1",                      Line:  1, Column: 10 ),
         new("FunctionForeach.ps1",                     Line:  5, Column: 11 ),
         new("FunctionForeachObject.ps1",               Line:  5, Column: 11 ),
-        new("FunctionInnerIsNested.ps1",               Line:  5, Column:  5  , "bar"),
+        new("FunctionInnerIsNested.ps1",               Line:  5, Column:  5 ),
         new("FunctionLoop.ps1",                        Line:  5, Column:  5 ),
         new("FunctionMultipleOccurrences.ps1",         Line:  5, Column:  3 ),
         new("FunctionNestedRedefinition.ps1",          Line: 13, Column: 15 ),
         new("FunctionOuterHasNestedFunction.ps1",      Line:  2, Column: 15 ),
-        new("FunctionSameName.ps1",                    Line:  3, Column:  14 , "RenamedSameNameFunction"),
+        new("FunctionSameName.ps1",                    Line:  3, Column: 14 , "RenamedSameNameFunction"),
         new("FunctionScriptblock.ps1",                 Line:  5, Column:  5 ),
         new("FunctionsSingle.ps1",                     Line:  1, Column: 11 ),
-        new("FunctionWithInnerFunction.ps1",           Line:  5, Column:  5  , "RenamedInnerFunction"),
+        new("FunctionWithInnerFunction.ps1",           Line:  5, Column:  5 ),
         new("FunctionWithInternalCalls.ps1",           Line:  3, Column:  6 ),
     ];
 }