Add prototypes for functions returning pointers and modify how some arrays are defined

Functions not declared before use, are define as returning an int.
Under 64-bit this can result in corrupted pointers being returned.

Also, Visual studio doesn't like it when you use variables to declare
array sizes, static values always work though.

Author: dkulwin

contrib/win32/win32compat/pwd.c

@@ -43,6 +43,8 @@
 #include "homedirhelp.h"
 
 
+char *GetHomeDirFromToken(char *userName, HANDLE token);
+
 uid_t getuid(void)
 {
   return 0;

readpass.c

@@ -146,7 +146,7 @@ ssh_askpass(char *askpass, const char *msg)
 
   int length = 8192;
 
-  CHAR command[length];
+  CHAR command[8192];
 
   char *pass = NULL;
 

serverloop.c

@@ -824,6 +824,10 @@ server_loop(pid_t pid, int fdin_arg, int fdout_arg, int fderr_arg)
 	/* NOTREACHED */
 }
 
+#ifdef WIN32_FIXME
+Session * session_get(int *);
+#endif
+
 static void
 collect_children(void)
 {

session.c

@@ -105,6 +105,8 @@
 #include "sftp.h"
 
 #ifdef WIN32_FIXME
+
+char *GetHomeDirFromToken(char *userName, HANDLE token);
 /*
 FIXME: GFPZR: Function stat() may be undeclared.
 */
@@ -873,7 +875,7 @@ do_exec_no_pty(Session *s, const char *command)
 
   DWORD size = 256;
 
-  char name[size];
+  char name[256];
 
   GetUserName(name, &size);