Skip to content

Commit 0dd6d2c

Browse files
authored
username logging fix (#762)
* initial pass at including username from sftp * initialize user to unknown * update tests * fix spacing * fix test take 2
1 parent 27f6cfa commit 0dd6d2c

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

monitor.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -483,14 +483,14 @@ monitor_read_log(struct monitor *pmonitor)
483483

484484
/*log it*/
485485
if (authctxt->authenticated == 0)
486-
sshlogdirect(level, forced, "%s [preauth]", msg);
486+
sshlogdirect(level, forced, "user: %s: %s [preauth]", authctxt->user, msg);
487487
else {
488488
if (strcmp(pname, "sftp-server") == 0) {
489489
log_init(pname, sftp_log_level, sftp_log_facility, sftp_log_stderr);
490-
sshlogdirect(level, forced, "%s", msg);
490+
sshlogdirect(level, forced, "user: %s: %s", authctxt->user, msg);
491491
log_init("sshd", options.log_level, options.log_facility, log_stderr);
492492
} else
493-
sshlogdirect(level, forced, "%s", msg);
493+
sshlogdirect(level, forced, "user: %s: %s", authctxt->user, msg);
494494
}
495495
#else
496496
/*log it*/

regress/pesterTests/FileBasedLogging.tests.ps1

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -200,9 +200,9 @@ exit"
200200

201201
$sshdlog | Should Contain "Accepted publickey for $nonadminusername"
202202
$sshdlog | Should Contain "KEX done \[preauth\]"
203-
$sshdlog | Should Contain "debug2: subsystem request for sftp by user $nonadminusername"
203+
$sshdlog | Should Contain "debug2: user: $nonadminusername`: subsystem request for sftp by user $nonadminusername"
204204
$sftplog | Should Contain "session opened for local user $nonadminusername"
205-
$sftplog | Should Contain "debug3: request 3: opendir"
205+
$sftplog | Should Contain "debug3: user: $nonadminusername`: request 3: opendir"
206206
$sftplog | Should Contain "session closed for local user $nonadminusername"
207207
}
208208

@@ -216,9 +216,9 @@ exit"
216216

217217
$sshdlog | Should Contain "Accepted publickey for $adminusername"
218218
$sshdlog | Should Contain "KEX done \[preauth\]"
219-
$sshdlog | Should Contain "debug2: subsystem request for sftp by user $adminusername"
219+
$sshdlog | Should Contain "debug2: user: $adminusername`: subsystem request for sftp by user $adminusername"
220220
$sftplog | Should Contain "session opened for local user $adminusername"
221-
$sftplog | Should Contain "debug3: request 3: opendir"
221+
$sftplog | Should Contain "debug3: user: $adminusername`: request 3: opendir"
222222
$sftplog | Should Contain "session closed for local user $adminusername"
223223
}
224224
}

0 commit comments

Comments
 (0)