Skip to content

Commit 6e3fb28

Browse files
committed
Remove unused INotebooksSettings
This feature never made it out of preview.
1 parent 5cae711 commit 6e3fb28

File tree

1 file changed

+0
-11
lines changed

1 file changed

+0
-11
lines changed

src/settings.ts

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,6 @@ export interface ISettings {
9898
pester: IPesterSettings;
9999
buttons?: IButtonSettings;
100100
cwd?: string;
101-
notebooks?: INotebooksSettings;
102101
enableReferencesCodeLens?: boolean;
103102
analyzeOpenDocumentsOnly?: boolean;
104103
}
@@ -132,10 +131,6 @@ export interface IButtonSettings {
132131
showPanelMovementButtons?: boolean;
133132
}
134133

135-
export interface INotebooksSettings {
136-
saveMarkdownCellsAs?: CommentType;
137-
}
138-
139134
// TODO: This could probably be async, and call `validateCwdSetting()` directly.
140135
export function load(): ISettings {
141136
const configuration: vscode.WorkspaceConfiguration =
@@ -219,10 +214,6 @@ export function load(): ISettings {
219214
debugOutputVerbosity: "Diagnostic",
220215
};
221216

222-
const defaultNotebooksSettings: INotebooksSettings = {
223-
saveMarkdownCellsAs: CommentType.BlockComment,
224-
};
225-
226217
// TODO: I believe all the defaults can be removed, as the `package.json` should supply them (and be the source of truth).
227218
return {
228219
startAutomatically:
@@ -261,8 +252,6 @@ export function load(): ISettings {
261252
configuration.get<IPesterSettings>("pester", defaultPesterSettings),
262253
buttons:
263254
configuration.get<IButtonSettings>("buttons", defaultButtonSettings),
264-
notebooks:
265-
configuration.get<INotebooksSettings>("notebooks", defaultNotebooksSettings),
266255
startAsLoginShell:
267256
// We follow the same convention as VS Code - https://github.com/microsoft/vscode/blob/ff00badd955d6cfcb8eab5f25f3edc86b762f49f/src/vs/workbench/contrib/terminal/browser/terminal.contribution.ts#L105-L107
268257
// "Unlike on Linux, ~/.profile is not sourced when logging into a macOS session. This

0 commit comments

Comments
 (0)