Skip to content

Commit 7fb4033

Browse files
author
Kapil Borle
committed
Pass settings object for codeformatting
1 parent 08bdc0f commit 7fb4033

File tree

1 file changed

+12
-22
lines changed

1 file changed

+12
-22
lines changed

src/features/DocumentFormatter.ts

Lines changed: 12 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ export namespace ScriptFileMarkersRequest {
2626
// TODO move some of the common interface to a separate file?
2727
interface ScriptFileMarkersRequestParams {
2828
filePath: string;
29-
settings: string;
29+
settings: any;
3030
}
3131

3232
interface ScriptFileMarkersRequestResultParams {
@@ -219,38 +219,28 @@ class PSDocumentFormattingEditProvider implements DocumentFormattingEditProvider
219219
this.languageClient = languageClient;
220220
}
221221

222-
getSettings(rule: string): string {
223-
let settings: Settings.ISettings = Settings.load(Utils.PowerShellLanguageId);
224-
let ruleProperty: string;
222+
getSettings(rule: string): any {
223+
let psSettings: Settings.ISettings = Settings.load(Utils.PowerShellLanguageId);
224+
let ruleSettings = new Object();
225+
ruleSettings["Enable"] = true;
226+
225227
switch (rule) {
226228
case "PSPlaceOpenBrace":
227-
ruleProperty = `${rule} = @{
228-
Enable = \$true
229-
OnSameLine = \$${settings.codeFormatting.openBraceOnSameLine}
230-
NewLineAfter = \$${settings.codeFormatting.newLineAfterOpenBrace}
231-
}`;
229+
ruleSettings["OnSameLine"] = psSettings.codeFormatting.openBraceOnSameLine;
230+
ruleSettings["NewLineAfter"] = psSettings.codeFormatting.newLineAfterOpenBrace;
232231
break;
233232

234233
case "PSUseConsistentIndentation":
235-
ruleProperty = `${rule} = @{
236-
Enable = \$true
237-
IndentationSize = ${vscode.workspace.getConfiguration("editor").get<number>("tabSize")}
238-
}`;
234+
ruleSettings["IndentationSize"] = vscode.workspace.getConfiguration("editor").get<number>("tabSize");
239235
break;
240236

241237
default:
242-
ruleProperty = `${rule} = @{
243-
Enable = \$true
244-
}`;
245238
break;
246239
}
247240

248-
return `@{
249-
IncludeRules = @('${rule}')
250-
Rules = @{
251-
${ruleProperty}
252-
}
253-
}`;
241+
let settings: Object = new Object();
242+
settings[rule] = ruleSettings;
243+
return settings;
254244
}
255245
}
256246

0 commit comments

Comments
 (0)