Fix errors gathering the forest SID

mbrancato · web-flow · commit d1060930c7af · 2017-01-04T23:23:25.000-05:00
Pull the SID directly from the 'krbtgt' user to avoid errors in ConvertTo-SID
diff --git a/Recon/PowerView.ps1 b/Recon/PowerView.ps1
@@ -3891,10 +3891,10 @@ to the forest root domain SID.
         if ($ForestObject) {
             # get the SID of the forest root
             if ($PSBoundParameters['Credential']) {
-                $ForestSid = ConvertTo-SID -ObjectName "krbtgt@$($ForestObject.RootDomain)" -Credential $Credential
+                $ForestSid = (Get-DomainUser -Identity "krbtgt" -Domain $ForestObject.RootDomain.Name -Credential $Credential).objectsid
             }
             else {
-                $ForestSid = ConvertTo-SID -ObjectName "krbtgt@$($ForestObject.RootDomain)"
+                $ForestSid = (Get-DomainUser -Identity "krbtgt" -Domain $ForestObject.RootDomain.Name).objectsid
             }
 
             $Parts = $ForestSid -Split '-'

Original file line number	Diff line number	Diff line change
`@@ -3891,10 +3891,10 @@ to the forest root domain SID.`
`3891`	`3891`	`if ($ForestObject) {`
`3892`	`3892`	`# get the SID of the forest root`
`3893`	`3893`	`if ($PSBoundParameters['Credential']) {`
`3894`		`- $ForestSid = ConvertTo-SID -ObjectName "krbtgt@$($ForestObject.RootDomain)" -Credential $Credential`
	`3894`	`+ $ForestSid = (Get-DomainUser -Identity "krbtgt" -Domain $ForestObject.RootDomain.Name -Credential $Credential).objectsid`
`3895`	`3895`	`}`
`3896`	`3896`	`else {`
`3897`		`- $ForestSid = ConvertTo-SID -ObjectName "krbtgt@$($ForestObject.RootDomain)"`
	`3897`	`+ $ForestSid = (Get-DomainUser -Identity "krbtgt" -Domain $ForestObject.RootDomain.Name).objectsid`
`3898`	`3898`	`}`
`3899`	`3899`
`3900`	`3900`	`$Parts = $ForestSid -Split '-'`